From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D4EC3815B for ; Mon, 20 Apr 2020 07:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12C2D2078C for ; Mon, 20 Apr 2020 07:37:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s9Ej0RPY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725971AbgDTHhU (ORCPT ); Mon, 20 Apr 2020 03:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbgDTHhU (ORCPT ); Mon, 20 Apr 2020 03:37:20 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDDF0C061A0F for ; Mon, 20 Apr 2020 00:37:19 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 188so3671427wmc.2 for ; Mon, 20 Apr 2020 00:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=x4d8njD2ChzZ2kuDWBQWJtIw3UQE6E7sHmhOoB5ezqs=; b=s9Ej0RPYb9lJkeS+N4KaZqRVDOm/SMTuNsIfiyVl/sCG8tzdLnNngYV+RVgyER1R3F VRzB6TNY6rn0cuPvz+jDOcsgEm6vB1iflYdPxH4S/bamY84eTcqa+4vtDy05GKDS4zS0 Kmm16bHrfBNiQYXYskNt3fsMJzTC+pNl8kFLLFI9UFzWOxH8F7RfDCklTUfNpN0f2I44 VR2D/sc2g96ROMto0j2Rr+t14rZ1StFnVNPpwNhsirhV/Pqwh8cGs84i9OzxMvWPinBI Lffym77ABv9sVKQAf5rNjW5F0P8/MHbhNn36a9zIpouhrv8SW+gc2OjC9ud+o76ZOm5t peAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=x4d8njD2ChzZ2kuDWBQWJtIw3UQE6E7sHmhOoB5ezqs=; b=lHqF/rIvy3fS0LWPu+mszWCWXfUJapP9TCg4bte2aNTULjvjftcs+D5CsT71Iui78c NIpY3HXj/oFm4WSrhU5fuPxwRPZgQ9dZQJ5s9mXjxzbKcCL9prooGee79TNKUSp7vtym PfVLfCqAbiZLbKJSTl99HU11AyMS+JP80H10IzwfUGBgtUwhhacJetesCR84F73YkvGw pxT9NoOs0rSoF/VtnpeJTQF2/LENuknquGMDAhb66ir9ElW0y363a6y4Ho2iwflC4Tq2 SVTfRUhMuWCr6Jk4CQ3vBsI6NjUk386UXajZ7C1h1HNQ0RlipCLiaY2SJJWkuDl0SduM jbEQ== X-Gm-Message-State: AGi0PuYBgEdiwec+49eGUyfXF1Rune1aSI3V5FNmg23Htdm/DiBmiA3l ratfUr2I07AkG9ZxMhF0AEyXCg== X-Google-Smtp-Source: APiQypI3JmmCDHjcMn3A1vzcEpxgsLlbI4LO3mEsYg5l0mrqs5au0PNliOvfe+fdVwtahiKITEMREQ== X-Received: by 2002:a1c:6344:: with SMTP id x65mr16504650wmb.56.1587368238713; Mon, 20 Apr 2020 00:37:18 -0700 (PDT) Received: from dell ([95.149.164.107]) by smtp.gmail.com with ESMTPSA id y40sm43875wrd.20.2020.04.20.00.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 00:37:18 -0700 (PDT) Date: Mon, 20 Apr 2020 08:37:16 +0100 From: Lee Jones To: Ran Bi Cc: Hsin-Hsiung Wang , Rob Herring , Matthias Brugger , Alexandre Belloni , Nicolas Boichat , Mark Rutland , Sean Wang , Sebastian Reichel , Eddie Huang , Alessandro Zummo , Kate Stewart , Richard Fontana , Frank Wunderlich , Josef Friedl , Thomas Gleixner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358 RTC Message-ID: <20200420073716.GM3737@dell> References: <1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com> <20200416091438.GA2167633@dell> <1587112169.12875.2.camel@mhfsdcap03> <1587113392.13323.3.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1587113392.13323.3.camel@mhfsdcap03> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 17 Apr 2020, Ran Bi wrote: > On Fri, 2020-04-17 at 16:29 +0800, Ran Bi wrote: > > On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote: > > > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote: > > > > > > > From: Ran Bi > > > > > > > > This add support for the MediaTek MT6358 RTC. Driver using > > > > compatible data to store different RTC_WRTGR address offset. > > > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff > > > > driver which only needed by armv7 CPU without ATF. > > > > > > > > Reviewed-by: Nicolas Boichat > > > > Reviewed-by: Yingjoe Chen > > > > Acked-by: Alexandre Belloni > > > > Acked-by: Sebastian Reichel > > > > Signed-off-by: Ran Bi > > > > Signed-off-by: Hsin-Hsiung Wang > > > > > > Please place these in chronological order. They should provide some > > > history, rather than a unordered slab list of random sign-offs. > > > > > > > I suppose that you mean the order should be like below, right? > > Reviewed-by: Yingjoe Chen > > Acked-by: Sebastian Reichel > > Acked-by: Alexandre Belloni > > Reviewed-by: Nicolas Boichat > > Signed-off-by: Hsin-Hsiung Wang > > Signed-off-by: Ran Bi > > > > Correction, I think following is the correct chronological order: > Signed-off-by: Ran Bi > Signed-off-by: Hsin-Hsiung Wang > Reviewed-by: Nicolas Boichat > Acked-by: Alexandre Belloni > Acked-by: Sebastian Reichel > Reviewed-by: Yingjoe Chen This looks better, yes. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog