From: Boris Brezillon <boris.brezillon@collabora.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, arnd@arndb.de,
brendanhiggins@google.com, tglx@linutronix.de,
anders.roxell@linaro.org, masonccyang@mxic.com.tw,
piotrs@cadence.com, robh+dt@kernel.org,
linux-mips@vger.kernel.org, hauke.mehrtens@intel.com,
qi-ming.wu@intel.com, cheol.yong.kim@intel.com
Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Mon, 20 Apr 2020 11:17:54 +0200 [thread overview]
Message-ID: <20200420111754.5863324b@collabora.com> (raw)
In-Reply-To: <20200419222040.GJ185537@smile.fi.intel.com>
On Mon, 20 Apr 2020 01:20:40 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sat, Apr 18, 2020 at 10:55:33AM +0200, Boris Brezillon wrote:
> > On Fri, 17 Apr 2020 16:21:47 +0800
> > "Ramuthevar,Vadivel MuruganX"
> > <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> >
> > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> > > +static const struct of_device_id lgm_nand_match[] = {
> > > + { .compatible = "intel,lgm-nand", },
> > > + {}
> > > +};
> > > +MODULE_DEVICE_TABLE(of, lgm_nand_match);
> >
> > You probably have a missing "depends on OF" in your Kconfig.
>
> Since it's using device property API, dependency is not needed.
>
There's no compile-time dependency, but this driver will be pretty
useless if all its users have the NAND controller node defined in their
DT and CONFIG_OF is not enabled. I guess the OF option is selected by
arches, so explicitly depending on OF is only relevant if you change
the dependency rules as suggested in my other reply.
next prev parent reply other threads:[~2020-04-20 9:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 8:21 [PATCH v2 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-17 8:21 ` [PATCH v2 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Ramuthevar,Vadivel MuruganX
2020-04-17 8:21 ` [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-17 17:05 ` Hauke Mehrtens
2020-04-20 3:49 ` Ramuthevar, Vadivel MuruganX
2020-04-18 8:55 ` Boris Brezillon
2020-04-19 22:20 ` Andy Shevchenko
2020-04-20 9:17 ` Boris Brezillon [this message]
2020-04-20 9:44 ` Andy Shevchenko
2020-04-20 9:52 ` Boris Brezillon
2020-04-20 10:14 ` Andy Shevchenko
2020-04-20 10:28 ` Boris Brezillon
2020-04-20 10:41 ` Andy Shevchenko
2020-04-20 11:06 ` Boris Brezillon
2020-04-20 4:18 ` Ramuthevar, Vadivel MuruganX
2020-04-20 7:40 ` Boris Brezillon
2020-04-20 8:51 ` Ramuthevar, Vadivel MuruganX
2020-04-27 15:38 ` Miquel Raynal
2020-04-27 18:30 ` Boris Brezillon
2020-04-19 22:28 ` Andy Shevchenko
2020-04-20 3:28 ` Ramuthevar, Vadivel MuruganX
2020-04-20 8:29 ` Boris Brezillon
2020-04-20 9:15 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420111754.5863324b@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke.mehrtens@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=piotrs@cadence.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).