* [PATCH] of: fix the warnings from command line.
@ 2020-04-10 8:32 tangjianqiang
2020-04-10 13:39 ` Frank Rowand
2020-04-20 18:43 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: tangjianqiang @ 2020-04-10 8:32 UTC (permalink / raw)
To: Frank Rowand, Rob Herring, devicetree; +Cc: Tang Jianqiang, tangjianqiang
Gerrit will complain with this warnings:
ERROR: (foo*) should be (foo *)
Signed-off-by: tangjianqiang <tangjianqiang@xiaomi.com>
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 2cdf64d..8a8e07a 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -1078,7 +1078,7 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,
#endif
#endif /* CONFIG_CMDLINE */
- pr_debug("Command line is: %s\n", (char*)data);
+ pr_debug("Command line is: %s\n", (char *)data);
rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
if (rng_seed && l > 0) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fix the warnings from command line.
2020-04-10 8:32 [PATCH] of: fix the warnings from command line tangjianqiang
@ 2020-04-10 13:39 ` Frank Rowand
2020-04-20 18:43 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Frank Rowand @ 2020-04-10 13:39 UTC (permalink / raw)
To: tangjianqiang, Rob Herring, devicetree; +Cc: tangjianqiang
On 4/10/20 3:32 AM, tangjianqiang wrote:
> Gerrit will complain with this warnings:
> ERROR: (foo*) should be (foo *)
>
> Signed-off-by: tangjianqiang <tangjianqiang@xiaomi.com>
> ---
> drivers/of/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 2cdf64d..8a8e07a 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1078,7 +1078,7 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,
> #endif
> #endif /* CONFIG_CMDLINE */
>
> - pr_debug("Command line is: %s\n", (char*)data);
> + pr_debug("Command line is: %s\n", (char *)data);
>
> rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
> if (rng_seed && l > 0) {
>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fix the warnings from command line.
2020-04-10 8:32 [PATCH] of: fix the warnings from command line tangjianqiang
2020-04-10 13:39 ` Frank Rowand
@ 2020-04-20 18:43 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-04-20 18:43 UTC (permalink / raw)
To: tangjianqiang; +Cc: Frank Rowand, devicetree, Tang Jianqiang, tangjianqiang
On Fri, 10 Apr 2020 16:32:04 +0800, tangjianqiang wrote:
> Gerrit will complain with this warnings:
> ERROR: (foo*) should be (foo *)
>
> Signed-off-by: tangjianqiang <tangjianqiang@xiaomi.com>
> ---
> drivers/of/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-10 8:32 [PATCH] of: fix the warnings from command line tangjianqiang
2020-04-10 13:39 ` Frank Rowand
2020-04-20 18:43 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).