From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: fix pm8150 gpio interrupts
Date: Mon, 20 Apr 2020 12:43:59 -0700 [thread overview]
Message-ID: <20200420194359.GP576963@builder.lan> (raw)
In-Reply-To: <20200420153543.14512-1-jonathan@marek.ca>
On Mon 20 Apr 08:35 PDT 2020, Jonathan Marek wrote:
> This was mistakenly copied from the downstream dts, however the upstream
> driver works differently.
>
> I only tested this with the pm8150_gpios node (used with volume button),
> but the 2 others should be the same.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Applied, thanks Jonathan
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/pm8150.dtsi | 14 ++------------
> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 14 ++------------
> arch/arm64/boot/dts/qcom/pm8150l.dtsi | 14 ++------------
> 3 files changed, 6 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> index b6e304748a57..c0b197458665 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> @@ -73,18 +73,8 @@ pm8150_gpios: gpio@c000 {
> reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> - interrupts = <0x0 0xc0 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc1 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc2 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc3 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc4 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc5 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc6 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc7 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc8 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xc9 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xca 0x0 IRQ_TYPE_NONE>,
> - <0x0 0xcb 0x0 IRQ_TYPE_NONE>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> index 322379d5c31f..40b5d75a4a1d 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -62,18 +62,8 @@ pm8150b_gpios: gpio@c000 {
> reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> - interrupts = <0x2 0xc0 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc1 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc2 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc3 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc4 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc5 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc6 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc7 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc8 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xc9 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xca 0x0 IRQ_TYPE_NONE>,
> - <0x2 0xcb 0x0 IRQ_TYPE_NONE>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> index eb0e9a090e42..cf05e0685d10 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> @@ -56,18 +56,8 @@ pm8150l_gpios: gpio@c000 {
> reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> - interrupts = <0x4 0xc0 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc1 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc2 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc3 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc4 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc5 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc6 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc7 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc8 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xc9 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xca 0x0 IRQ_TYPE_NONE>,
> - <0x4 0xcb 0x0 IRQ_TYPE_NONE>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> };
>
> --
> 2.26.1
>
prev parent reply other threads:[~2020-04-20 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 15:35 [PATCH] arm64: dts: qcom: fix pm8150 gpio interrupts Jonathan Marek
2020-04-20 19:43 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420194359.GP576963@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).