From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDD3C38A30 for ; Tue, 21 Apr 2020 01:53:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA2342078C for ; Tue, 21 Apr 2020 01:53:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xfRpFDiM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbgDUBxZ (ORCPT ); Mon, 20 Apr 2020 21:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725829AbgDUBxZ (ORCPT ); Mon, 20 Apr 2020 21:53:25 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D98C061A0E for ; Mon, 20 Apr 2020 18:53:25 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id x26so6020561pgc.10 for ; Mon, 20 Apr 2020 18:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HjaU46gshLP9GG/96K+kwboQDvDrw0plitPA+YNIbGk=; b=xfRpFDiMGDmWjPTE0YYkUbpZVS47obtstRXpn7KoJtKrL2QbpLZfww1X3ZSIh8l0Nv n+sW9vfTuCEWuxgnENefnuyqJYDmvX0Xl9dbhxiDUU27U/ZaeXsqr7inv+SvEh78uAbg hZf8+Hox1ek/VyaKJyo68zPK/KFaqwxdO/NGoD8pLBlemT0P10eClmNQgU/SiT0rYoAm nvAiyJ857Lcxcgb4dBbMQGn+gfn3MGQej9GLjYxXrPpZ4MHMD5Gx42i7SqCQ51uExIAg XAzv9LqBijXqE+nnbh6rGyQs+EIjq58AiGqemnn/IX9SW/1bnrw70pFKeBSsc5tEX0oQ 8rpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HjaU46gshLP9GG/96K+kwboQDvDrw0plitPA+YNIbGk=; b=gwjgUYkb0yPO7qQ1n+UFlz0zrpe7sHLyaRJLapPqDbhVAtS8tZ4jHaQgfOnfMOds6G r+4qoRYA57N7cMGDKkAaM0qpb4C6XrTCvwB/vLy/WJBRP0TFzygbAlsjHaBJjs6yJqOj q+OIKs0q6nVT1rSkP1xqKFLZ2z+9yIgyPCEr3asB7hwzLw3Pcb+Bn9ekbkezanlUQfle IHkdV6ePoVeitaHzbiA1WvHZzvaaeax7t7BEVnmuIgVpdoTWfM2JdYBqDBwmHzni58MB eyiF/0GXXE5xppD06RPTvFKKfI9G0mp1I1hiR/0UR2HMLXhYFOxi5C4aLpUMUfaM8aDA ne4g== X-Gm-Message-State: AGi0PuahR5n0Fmk+pXUXIZEZaQhUMP9W1+mCwLQ2vnGBoYLQiXpgpmku lVO39jqwJsnK4wf76aXU46YMyw== X-Google-Smtp-Source: APiQypI4Nxn9X9fDUlEU6GiIiPgk4BM6mX4SRxaaBvw8cFMIqbkz4RbBzf6gfeDAsH3XeeLgbtcPOw== X-Received: by 2002:a63:310d:: with SMTP id x13mr7596695pgx.266.1587434004255; Mon, 20 Apr 2020 18:53:24 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id s10sm657737pgq.69.2020.04.20.18.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 18:53:23 -0700 (PDT) Date: Mon, 20 Apr 2020 18:53:47 -0700 From: Bjorn Andersson To: Stephan Gerhold Cc: Rob Herring , Andy Gross , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Srinivas Kandagatla Subject: Re: [PATCH 2/2] dt-bindings: soc: qcom: apr: Use generic node names for APR services Message-ID: <20200421015347.GT576963@builder.lan> References: <20200415081159.1098-1-stephan@gerhold.net> <20200415081159.1098-2-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200415081159.1098-2-stephan@gerhold.net> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 15 Apr 01:11 PDT 2020, Stephan Gerhold wrote: > Device nodes should be named according to the class of devices > they belong to. Change the suggested names of the subnodes to > apr-service@, which is already in use in > arch/arm64/boot/dts/qcom/sdm845.dtsi. > > Cc: Srinivas Kandagatla > Signed-off-by: Stephan Gerhold Applied, thank you. > --- > .../devicetree/bindings/soc/qcom/qcom,apr.txt | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > index f8fa71f5d84b..2e2f6dc351c0 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > @@ -65,30 +65,30 @@ which uses apr as communication between Apps and QDSP. > compatible = "qcom,apr-v2"; > qcom,apr-domain = ; > > - q6core@3 { > + apr-service@3 { > compatible = "qcom,q6core"; > reg = ; > }; > > - q6afe@4 { > + apr-service@4 { > compatible = "qcom,q6afe"; > reg = ; > > dais { > #sound-dai-cells = <1>; > - hdmi@1 { > - reg = <1>; > + dai@1 { > + reg = ; > }; > }; > }; > > - q6asm@7 { > + apr-service@7 { > compatible = "qcom,q6asm"; > reg = ; > ... > }; > > - q6adm@8 { > + apr-service@8 { > compatible = "qcom,q6adm"; > reg = ; > ... > @@ -106,26 +106,26 @@ have no such dependency. > qcom,glink-channels = "apr_audio_svc"; > qcom,apr-domain = ; > > - q6core { > + apr-service@3 { > compatible = "qcom,q6core"; > reg = ; > }; > > - q6afe: q6afe { > + q6afe: apr-service@4 { > compatible = "qcom,q6afe"; > reg = ; > qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > ... > }; > > - q6asm: q6asm { > + q6asm: apr-service@7 { > compatible = "qcom,q6asm"; > reg = ; > qcom,protection-domain = "tms/servreg", "msm/slpi/sensor_pd"; > ... > }; > > - q6adm: q6adm { > + q6adm: apr-service@8 { > compatible = "qcom,q6adm"; > reg = ; > qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > -- > 2.26.1 >