Re: [PATCH v3 2/5] ARM: dts: add Protonic PRTI6Q board

[Oleksij Rempel <o.rempel@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]

On Tue, Apr 21, 2020 at 09:37:13AM +0200, Oleksij Rempel wrote:
> Hi Shawn,
> 
> Thank you for the review. You was reviewing v3, the last version is v5.
> Never the less, part of comments still apply. I'll fix them.
> 
> 
> On Tue, Apr 21, 2020 at 12:07:49PM +0800, Shawn Guo wrote:
> > On Tue, Mar 24, 2020 at 12:04:29PM +0100, Oleksij Rempel wrote:
> > > Protonic PRTI6Q is a development board and a base class for different
> > > specific customer application boards based on the i.MX6 family of SoCs,
> > > developed by Protonic Holland.
> > > 
> > > Signed-off-by: David Jander <david@protonic.nl>
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> 
> > > +&usdhc2 {
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&pinctrl_usdhc2>;
> > > +	non-removable;
> > > +	vmmc-supply = <&reg_wifi>;
> > > +	cap-power-off-card;
> > > +	keep-power-in-suspend;
> > > +	status = "okay";
> > > +
> > > +	wifi {
> > > +		compatible = "ti,wl1271";
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&pinctrl_wifi>;
> > > +		irq-gpio = <&gpio1 30 GPIO_ACTIVE_HIGH>;
> > 
> > I failed to find this in "ti,wl1271" bindings.
> 
> Indeed. But it is required by the code:
> 
> drivers/net/wireless/ti/wlcore/sdio.c:
> static int wlcore_probe_of(struct device *dev, int *irq, int *wakeirq,
> 			   struct wlcore_platdev_data *pdev_data)
> {
> ....
> 	*irq = irq_of_parse_and_map(np, 0);
> 	if (!*irq) {
> 		dev_err(dev, "No irq in platform data\n");
> 		return -EINVAL;
> 	}
> 
> I'll send a patch to fix it.


Ah.. forget it, my mistake. It should be interrupts.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]