From: Matthias Kaehlcke <mka@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
akashast@codeaurora.org, rojay@codeaurora.org,
msavaliy.qti.qualcomm.com@qualcomm.com
Subject: Re: [PATCH] arm64: dts: sc7180: Add wakeup support over UART RX
Date: Mon, 27 Apr 2020 09:56:16 -0700 [thread overview]
Message-ID: <20200427165616.GF4525@google.com> (raw)
In-Reply-To: <1587968844-26667-1-git-send-email-skakit@codeaurora.org>
Hi,
On Mon, Apr 27, 2020 at 11:57:24AM +0530, satya priya wrote:
> Add the necessary pinctrl and interrupts to make UART
> wakeup capable.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 4216b57..3a49603 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -637,9 +637,12 @@
> reg = <0 0x0088c000 0 0x4000>;
> clock-names = "se";
> clocks = <&gcc GCC_QUPV3_WRAP0_S3_CLK>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "sleep";
> pinctrl-0 = <&qup_uart3_default>;
> - interrupts = <GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-1 = <&qup_uart3_default>;
Why is the 'sleep' configuration needed if it's the same as 'default'?
> + interrupts-extended =
> + <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>,
> + <&tlmm 41 0>;
> status = "disabled";
> };
This patch only adds wakeup support for uart3, which seems an arbitrary
choice at SoC level. Either it should do it for all UARTs of the SC7180,
or in the .dtsi of devices that use UART3 and need it to be wakeup capable.
next prev parent reply other threads:[~2020-04-27 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 6:27 [PATCH] arm64: dts: sc7180: Add wakeup support over UART RX satya priya
2020-04-27 16:56 ` Matthias Kaehlcke [this message]
2020-07-24 3:56 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427165616.GF4525@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy.qti.qualcomm.com@qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).