From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, richard@nod.at, vigneshr@ti.com,
arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de,
anders.roxell@linaro.org, masonccyang@mxic.com.tw,
piotrs@cadence.com, robh+dt@kernel.org,
linux-mips@vger.kernel.org, hauke.mehrtens@intel.com,
andriy.shevchenko@intel.com, qi-ming.wu@intel.com,
cheol.yong.kim@intel.com
Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Mon, 27 Apr 2020 20:30:01 +0200 [thread overview]
Message-ID: <20200427203001.1d583322@collabora.com> (raw)
In-Reply-To: <20200427173846.3866c506@xps13>
On Mon, 27 Apr 2020 17:38:46 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@collabora.com> wrote on Sat, 18 Apr
> 2020 10:55:33 +0200:
>
> > On Fri, 17 Apr 2020 16:21:47 +0800
> > "Ramuthevar,Vadivel MuruganX"
> > <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> >
> > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> > >
> > > This patch adds the new IP of Nand Flash Controller(NFC) support
> > > on Intel's Lightning Mountain(LGM) SoC.
> > >
> > > DMA is used for burst data transfer operation, also DMA HW supports
> > > aligned 32bit memory address and aligned data access by default.
> > > DMA burst of 8 supported. Data register used to support the read/write
> > > operation from/to device.
> > >
> > > NAND controller driver implements ->exec_op() to replace legacy hooks,
> > > these specific call-back method to execute NAND operations.
> > >
> > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> > > ---
> > > drivers/mtd/nand/raw/Kconfig | 7 +
> > > drivers/mtd/nand/raw/Makefile | 1 +
> > > drivers/mtd/nand/raw/intel_lgm_nand.c | 740 ++++++++++++++++++++++++++++++++++
> >
> > I wonder if we shouldn't name the driver infineon-nand-controller.c
> > since the original design comes from Infineon IIUC. intel_lgm_nand.c is
> > definitely misleading, as we also have a nand_intel.c file which is for
> > Intel NAND chips (not NAND controllers). If we keep intel in the name,
> > let's at least add a "-controller" suffix to make it clear.
> >
> > Side note for Miquel: I guess we would also benefit from having a clear
> > core vs controller-drivers split as recently done for spi-nor (a
> > controller subdir has been created).
>
> I would even like a core vs controller drivers vs nand chips drivers.
>
> Macronix for instance has a NAND controller driver and a NAND chip
> driver, that's why, even if it is a bit long, I enforce the -nfc or
> -nand-controller (my favorite) suffix now.
Maybe we can make it happen. I mean, moving drivers to a sub-dir is
pretty easy ;).
next prev parent reply other threads:[~2020-04-27 18:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 8:21 [PATCH v2 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-17 8:21 ` [PATCH v2 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Ramuthevar,Vadivel MuruganX
2020-04-17 8:21 ` [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-17 17:05 ` Hauke Mehrtens
2020-04-20 3:49 ` Ramuthevar, Vadivel MuruganX
2020-04-18 8:55 ` Boris Brezillon
2020-04-19 22:20 ` Andy Shevchenko
2020-04-20 9:17 ` Boris Brezillon
2020-04-20 9:44 ` Andy Shevchenko
2020-04-20 9:52 ` Boris Brezillon
2020-04-20 10:14 ` Andy Shevchenko
2020-04-20 10:28 ` Boris Brezillon
2020-04-20 10:41 ` Andy Shevchenko
2020-04-20 11:06 ` Boris Brezillon
2020-04-20 4:18 ` Ramuthevar, Vadivel MuruganX
2020-04-20 7:40 ` Boris Brezillon
2020-04-20 8:51 ` Ramuthevar, Vadivel MuruganX
2020-04-27 15:38 ` Miquel Raynal
2020-04-27 18:30 ` Boris Brezillon [this message]
2020-04-19 22:28 ` Andy Shevchenko
2020-04-20 3:28 ` Ramuthevar, Vadivel MuruganX
2020-04-20 8:29 ` Boris Brezillon
2020-04-20 9:15 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427203001.1d583322@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke.mehrtens@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=piotrs@cadence.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).