From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: kgene@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] S5PV210 and Aries DTS improvements
Date: Tue, 28 Apr 2020 12:38:24 +0200 [thread overview]
Message-ID: <20200428103824.GF23963@kozik-lap> (raw)
In-Reply-To: <BN6PR04MB06601A5656CF70A4DCA7998BA3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
On Sun, Apr 26, 2020 at 11:35:51AM -0700, Jonathan Bakker wrote:
> This patchset makes several improvements to Aries devices which are
> based on S5PV210. Several pulls on GPIOs were incorrect/not specified,
> sleep GPIO configurations have been added, and more devices have been
> added.
>
> Touching the common S5PV210 DTSI are the addition of the ADC node
> as well as fixes to the FIMC definitions and a sleep GPIO helper
> added.
>
> The patches have been tested on both a GT-i9000 as well as an
> SGH-T959P and both can now suspend/resume properly.
>
> Jonathan Bakker (12):
> arm: dts: s5pv210: Add helper define for sleep gpio config
> arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration
> arm: dts: s5pv210: galaxys: Add sleep GPIO configuration
> arm: dts: s5pv210: aries: Set keep-power-in-suspend for SDHCI1
> arm: dts: s5pv210: aries: Disable pulls on GPIO i2c adapters
> arm: dts: s5pv210: aries: Add support for more devices
> arm: dts: s5pv210: aries: Disable pull for vibrator ena GPIO
> arm: dts: s5pv210: Add an ADC node
> arm: dts: s5pv210: aries: Enable ADC node
> arm: dts: s5pv210: Assign clocks to MMC devices
> arm: dts: s5pv210: Correct FIMC definitions
> arm: dts: s5pv210: aries: Set MAX8998 GPIO pulls
>
> Paweł Chmiel (1):
> arm: dts: s5pv210: galaxys: Add si470x fmradio
Thanks for the patches, nice work!
I commented on some of them. The other look good but I will wait with
applying for v2. When resending everything, change the subject of each
patch to match subsystem, so:
ARM: dts: s5pv210:
Best regards,
Krzysztof
prev parent reply other threads:[~2020-04-28 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 18:35 [PATCH 00/13] S5PV210 and Aries DTS improvements Jonathan Bakker
2020-04-28 10:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428103824.GF23963@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).