From: Rob Herring <robh@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: saravanak@google.com, linux-kernel@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v3 2/2] of: property: Do not link to disabled devices
Date: Tue, 28 Apr 2020 12:46:30 -0500 [thread overview]
Message-ID: <20200428174630.GA4698@bogus> (raw)
In-Reply-To: <20200420120101.31405-3-nsaenzjulienne@suse.de>
On Mon, 20 Apr 2020 14:01:02 +0200, Nicolas Saenz Julienne wrote:
> When creating a consumer/supplier relationship between two devices,
> make sure the supplier node is actually active. Otherwise this will
> create a link relationship that will never be fulfilled. This, in the
> worst case scenario, will hang the system during boot.
>
> Note that, in practice, the fact that a device-tree represented
> consumer/supplier relationship isn't fulfilled will not prevent devices
> from successfully probing.
>
> Fixes: a3e1d1a7f5fc ("of: property: Add functional dependency link from DT bindings")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> ---
>
> Changes since v2:
> - Correct code comment
> - Use already available return handling code
>
> Changes since v1:
> - Move availability check into the compatible search code and stop if
> node disabled
>
> drivers/of/property.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2020-04-28 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 12:00 [PATCH v3 0/2] of: property: fw_devlink misc fixes Nicolas Saenz Julienne
2020-04-20 12:01 ` [PATCH v3 1/2] of: property: Fix create device links for all child-supplier dependencies Nicolas Saenz Julienne
2020-04-28 17:45 ` Rob Herring
2020-04-20 12:01 ` [PATCH v3 2/2] of: property: Do not link to disabled devices Nicolas Saenz Julienne
2020-04-20 16:51 ` Saravana Kannan
2020-04-28 17:46 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428174630.GA4698@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).