From: Rob Herring <robh@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Lubomir Rintel <lkundrak@v3.sk>
Subject: Re: [PATCH v2 2/2] dt-bindings: serial: Convert 8250 to json-schema
Date: Thu, 30 Apr 2020 09:19:49 -0500 [thread overview]
Message-ID: <20200430141949.GA21645@bogus> (raw)
In-Reply-To: <20200419201716.679090-3-lkundrak@v3.sk>
On Sun, 19 Apr 2020 22:17:16 +0200, Lubomir Rintel wrote:
> Some fixes were done during the conversion:
>
> Slightly better examples. The original example was for an OMAP serial
> port, which is not even described by this binding, but by
> omap_serial.txt instead.
>
> Added compatible strings, that were used, byt not documented:
> andestech,uart16550, cavium,octeon-3860-uart, fsl,16550-FIFO64,
> nvidia,tegra186-uart, nvidia,tegra194-uart, nxp,lpc1850-uart,
> opencores,uart16550-rtlsvn105, ralink,mt7620a-uart, ralink,rt3052-uart,
> ralink,rt3883-uart and xlnx,xps-uart16550-2.00.b.
>
> Removed "serial" compatible string. It's redundant with the node name
> (which, in OFW, serves the same purpose as the compatible string).
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1, addressing review from Rob Herring [1]:
> - Utilize anyOf: instead of allOf: to express mutual exclusivity of
> clock-frequency and clocks.
> - Allow ns16550a where ns16550 is used but actually has a working FIFO;
> add a comment about ns16550a being preferred
> - resets: specify maxItems based on actual use, drop description
> - current-speed: add type ref
> - used-by-rtas: add type
> - no-loopback-test: add type, fix a typo in description
> - fifo-size: add type ref
> - auto-flow-control: add type
> - tx-threshold: add type ref
> - {rts,cts,dtr,dsr,rng,dcd}-gpios: drop description, redundant to
> serial.yaml
>
> [1] https://lore.kernel.org/lkml/CAL_Jsq+GDnYviCdszhghhEVB55giPHk8N9w_KASPXG_=H+ZQig@mail.gmail.com/
>
> .../devicetree/bindings/serial/8250.txt | 102 --------
> .../devicetree/bindings/serial/8250.yaml | 223 ++++++++++++++++++
> 2 files changed, 223 insertions(+), 102 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/serial/8250.txt
> create mode 100644 Documentation/devicetree/bindings/serial/8250.yaml
>
Applied, thanks.
Rob
prev parent reply other threads:[~2020-04-30 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 20:17 [PATCH v2 0/2] dt-bindings: serial: Convert 8250 to json-schema Lubomir Rintel
2020-04-19 20:17 ` [PATCH v2 1/2] dt-bindings: serial: Move Marvell compatible string to 8250 binding doc Lubomir Rintel
2020-04-30 14:19 ` Rob Herring
2020-04-19 20:17 ` [PATCH v2 2/2] dt-bindings: serial: Convert 8250 to json-schema Lubomir Rintel
2020-04-30 14:19 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430141949.GA21645@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).