From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C662C47254 for ; Fri, 1 May 2020 20:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFC392166E for ; Fri, 1 May 2020 20:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588364771; bh=X013ppbIzSl3+DV4yEIiVEG1A5SM/AeuoeMnWsxMbwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wllPko31zPsNOsLVZeX5VPFXAg6Gw0NOUvhl8fkIk5HbgoGBYLCT45LIRJchp7ipB mhdQZh+e7iBbjWd63B0JoBGCOZNGxnMD34ky+hTFTo+LI6EcYc8ohBBuGczSwUl/lo vdbE7jJRGawFbOnxosDx7XCg/RotGkjupU0MWl6U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726045AbgEAU0L (ORCPT ); Fri, 1 May 2020 16:26:11 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:39146 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbgEAU0K (ORCPT ); Fri, 1 May 2020 16:26:10 -0400 Received: by mail-oi1-f193.google.com with SMTP id m10so783649oie.6; Fri, 01 May 2020 13:26:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3KGOcilJxikkL+Nmr3AHMzqEO+ivM6wapTQZZpbzgL8=; b=cHzx/D+6hh3oQ2Aoh2VUNhvLlCnKcCmfUZOTTkiOJcIYP6M1SnFXfF2k3zyTcn9VdQ iPKYy2r5GNmm7xGfsp0zBJgDsX1Rb21KJgJEsbqUyDsqfD+e4fAySPjlAikXH378z77k qYHzjSt0g/T8uhavSA2FANNkTCyCePlVG0nZPVOcBvXMzr64DdxtTNYElMQeX3hV1hn/ 9aw0Du0ED3aUXCf2B2kEMPY7Ys/TkL/Oag3cSgBLG9NwoYihrTVQTer+EPWmOtCZuq9D iXEEiypKhJdus2Td/JFlvWjgaZLjujwbwI8uXPtkWsBLUZI8WgDmhkT9auiqWVFl0q9Z fH2g== X-Gm-Message-State: AGi0PuZ/O6PEzKyQ/GFhCwNj6IyBHokj+czZAlzIY7ehL4NMJWhW/nEt ZOirjRLBQ68lSLU3GynJzc9Ejh0= X-Google-Smtp-Source: APiQypKuIa2EayO6sRtISWTj8/Remk+FnQ3MtRzI4m9kvti4r3vQ9LWm9cRMPxzpDhc6m14oEPwVGg== X-Received: by 2002:aca:c311:: with SMTP id t17mr986175oif.169.1588364769215; Fri, 01 May 2020 13:26:09 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id f21sm213498oig.41.2020.05.01.13.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 13:26:08 -0700 (PDT) Received: (nullmailer pid 23725 invoked by uid 1000); Fri, 01 May 2020 20:26:07 -0000 Date: Fri, 1 May 2020 15:26:07 -0500 From: Rob Herring To: Adrian Ratiu Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Laurent Pinchart , Andrzej Hajda , Jonas Karlman , Jernej Skrabec , Heiko Stuebner , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-imx@nxp.com, kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com, Neil Armstrong , Fabio Estevam , Adrian Pop , Arnaud Ferraris , Sjoerd Simons , Martyn Welch Subject: Re: [PATCH v8 07/10] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Message-ID: <20200501202607.GA13720@bogus> References: <20200427081952.3536741-1-adrian.ratiu@collabora.com> <20200427081952.3536741-8-adrian.ratiu@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427081952.3536741-8-adrian.ratiu@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Apr 27, 2020 at 11:19:49AM +0300, Adrian Ratiu wrote: > This provides an example DT binding for the MIPI DSI host controller > present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. > > Cc: Rob Herring > Cc: Neil Armstrong > Cc: Fabio Estevam > Cc: Laurent Pinchart > Cc: devicetree@vger.kernel.org > Tested-by: Adrian Pop > Tested-by: Arnaud Ferraris > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch > Signed-off-by: Adrian Ratiu > --- > Changes since v7: > - Clarified port@0,1 descriptions, marked them as required and > added missing port@0 in example (Laurent) > > Changes since v6: > - Added ref to the newly created snps,dw-mipi-dsi.yaml (Laurent) > - Moved *-cells properties outside patternProperties (Laurent) > - Removed the panel port documentation (Laurent) > - Wrapped lines at 80 chars, typo fixes, sort includes (Laurent) > > Changes since v5: > - Fixed missing reg warning (Fabio) > - Updated dt-schema and fixed warnings (Rob) > > Changes since v4: > - Fixed yaml binding to pass `make dt_binding_check dtbs_check` > and addressed received binding feedback (Rob) > > Changes since v3: > - Added commit message (Neil) > - Converted to yaml format (Neil) > - Minor dt node + driver fixes (Rob) > - Added small panel example to the host controller binding > > Changes since v2: > - Fixed commit tags (Emil) > --- > .../display/imx/fsl,mipi-dsi-imx6.yaml | 145 ++++++++++++++++++ > 1 file changed, 145 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > new file mode 100644 > index 0000000000000..c2c3489e63fa3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > @@ -0,0 +1,145 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,mipi-dsi-imx6.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 DW MIPI DSI Host Controller > + > +maintainers: > + - Adrian Ratiu > + > +description: | > + The i.MX6 DSI host controller is a Synopsys DesignWare MIPI DSI v1.01 > + IP block with a companion PHY IP. > + > + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in > + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with > + the following device-specific properties. > + > +allOf: > + - $ref: ../bridge/snps,dw-mipi-dsi.yaml# > + > +properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + compatible: > + items: > + - const: fsl,imx6q-mipi-dsi > + - const: snps,dw-mipi-dsi This schema is going to be applied on any node with 'snps,dw-mipi-dsi'. You'll need a custom 'select' with only 'fsl,imx6q-mipi-dsi'. There's a few examples in the tree. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Module Clock > + - description: DSI bus clock > + > + clock-names: > + items: > + - const: ref > + - const: pclk > + > + fsl,gpr: > + description: > + Phandle to the iomuxc-gpr region containing the multiplexer ctrl register. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + ports: > + type: object > + description: | > + A node containing DSI input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt > + properties: > + port@0: > + type: object > + description: > + DSI input port connected to a parallel RGB LTDC output port. > + > + port@1: > + type: object > + description: > + DSI serial RGB output port connected to a panel or bridge input port. > + > + required: > + - port@0 > + - port@1 > + > +additionalProperties: false When including other schemas, you need 'unevalatedProperties: false' instead. Then you can drop anything here that doesn't have more constraints like the next property: > + > +patternProperties: > + "^panel@[0-3]$": > + type: object > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +examples: > + - |+ > + #include > + #include > + #include > + > + dsi: dsi@21e0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx6q-mipi-dsi", "snps,dw-mipi-dsi"; > + reg = <0x021e0000 0x4000>; > + interrupts = <0 102 IRQ_TYPE_LEVEL_HIGH>; > + fsl,gpr = <&gpr>; > + clocks = <&clks IMX6QDL_CLK_MIPI_CORE_CFG>, > + <&clks IMX6QDL_CLK_MIPI_IPG>; > + clock-names = "ref", "pclk"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + mipi_mux_0: endpoint { > + remote-endpoint = <&ipu1_di0_mipi>; > + }; > + }; > + port@1 { > + reg = <1>; > + dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "sharp,ls032b3sx01"; > + reg = <0>; > + reset-gpios = <&gpio6 8 GPIO_ACTIVE_LOW>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + }; > + }; > + > +... > -- > 2.26.0 >