From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexandru Ardelean" <alexandru.Ardelean@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v5 5/6] iio: imu: Add support for adis16475
Date: Sat, 2 May 2020 18:40:10 +0100 [thread overview]
Message-ID: <20200502184010.134eb8b5@archlinux> (raw)
In-Reply-To: <2418ed60-8407-0c99-bf5d-1afc3964de2b@metafoo.de>
On Mon, 27 Apr 2020 20:06:07 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 4/13/20 10:24 AM, Nuno Sá wrote:
> > [...]
> > +static irqreturn_t adis16475_trigger_handler(int irq, void *p)
> > +{
> > [...]
> > + __be16 data[ADIS16475_MAX_SCAN_DATA], *buffer;
> > [...]
> > +
> > + iio_push_to_buffers_with_timestamp(indio_dev, data, pf->timestamp);
>
> If the timestamp is enabled the IIO core might insert padding between
> the data channels and the timestamp. If that happens this will disclose
> kernel stack memory to userspace.
>
> This needs either a memset(data, 0x00, sizeof(data)) or maybe put data
> into the state struct and kzalloc it.
Good spot. Could simply do __be16 data[ADI..] = {0}; rather than explicit
memset, but some form of zeroization is needed.
I've fixed up the applied patch with the above approach.
Thanks,
Jonathan
>
> - Lars
>
next prev parent reply other threads:[~2020-05-02 17:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 8:24 [PATCH v5 0/6] Support ADIS16475 and similar IMUs Nuno Sá
2020-04-13 8:24 ` [PATCH v5 1/6] iio: imu: adis: Add Managed device functions Nuno Sá
2020-04-13 8:24 ` [PATCH v5 2/6] iio: imu: adis: Add irq flag variable Nuno Sá
2020-04-13 8:24 ` [PATCH v5 3/6] iio: adis: Add adis_update_bits() APIs Nuno Sá
2020-04-13 8:24 ` [PATCH v5 4/6] iio: adis: Support different burst sizes Nuno Sá
2020-04-13 8:24 ` [PATCH v5 5/6] iio: imu: Add support for adis16475 Nuno Sá
2020-04-27 18:06 ` Lars-Peter Clausen
2020-05-02 17:40 ` Jonathan Cameron [this message]
2020-05-02 18:01 ` Lars-Peter Clausen
2020-05-02 19:52 ` Nuno Sá
2020-05-03 8:47 ` Jonathan Cameron
2020-05-03 9:07 ` Lars-Peter Clausen
2020-05-03 9:12 ` Lars-Peter Clausen
2020-05-17 16:15 ` Jonathan Cameron
2020-05-17 19:07 ` Lars-Peter Clausen
2020-05-18 16:29 ` Jonathan Cameron
2020-05-03 11:07 ` Nuno Sá
2020-05-03 11:29 ` Jonathan Cameron
2020-05-03 17:19 ` Jonathan Cameron
2020-05-03 17:55 ` Nuno Sá
2020-04-13 8:24 ` [PATCH v5 6/6] dt-bindings: iio: Add adis16475 documentation Nuno Sá
2020-04-20 19:17 ` Rob Herring
2020-04-13 16:27 ` [PATCH v5 0/6] Support ADIS16475 and similar IMUs Jonathan Cameron
2020-04-25 15:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200502184010.134eb8b5@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nuno.sa@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).