devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>,
	Pavel Modilaynen <pavel.modilaynen@axis.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dtc: Use better check for libyaml
Date: Sat, 2 May 2020 20:16:21 +0200	[thread overview]
Message-ID: <20200502201621.2b93dda4@nic.cz> (raw)
In-Reply-To: <CAK7LNARo7tErhQzxsOktwrrBcu+W5Wz4VqadrcyiTRHeL6-F4w@mail.gmail.com>

On Sun, 3 May 2020 02:56:42 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> You missed to see the cost of parsing the Makefile.
> 
> 
> scripts/dtc/Makefile is parsed every time
> you run 'make'.
> 
> Even if you have nothing to recompile,
> it builds the tiny program in background.
> 
> This happens for 'make mrproper' too.

I missed this point by a large margin indeed.

> Maybe, file a bug report to your distribution
> if the pc file is strangely installed?
>
> ...

Very well, thank you for elaborating on that. Sorry this took your time.

Now that I know this, wouldn't it make more sense to decide
whether to build yamltree.c or not in config stage, eg. in a Kconfig
file? Because now it seems that pkg-config is being run everytime we run
make. I understand that it is much cheaper than gcc, but either way...

Marek

  reply	other threads:[~2020-05-02 18:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01  1:51 [PATCH] dtc: Use better check for libyaml Marek Behún
2020-05-01  5:27 ` Masahiro Yamada
2020-05-01 15:08   ` Marek Behun
2020-05-02 17:56     ` Masahiro Yamada
2020-05-02 18:16       ` Marek Behun [this message]
2020-05-04  1:34         ` Masahiro Yamada
2020-05-01 19:37 ` [PATCH v2] " Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200502201621.2b93dda4@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=pavel.modilaynen@axis.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).