From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: fsl_esai: introduce SoC specific data
Date: Mon, 4 May 2020 14:39:05 -0700 [thread overview]
Message-ID: <20200504213905.GA21292@Asurada-Nvidia> (raw)
In-Reply-To: <27af074e47bf2b81e2dce67ea66a9f7301dfcb07.1588320656.git.shengjiu.wang@nxp.com>
On Fri, May 01, 2020 at 04:12:04PM +0800, Shengjiu Wang wrote:
> Introduce a SoC specific data structure which contains the
> differences between the different SoCs.
> This makes it easier to support more differences without having
> to introduce a new if/else each time.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Though the 2nd patch is having comments to address, this one
looks fine to me and should be able to merge as long as Mark
is okay with this too:
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
next prev parent reply other threads:[~2020-05-04 21:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 8:12 [PATCH 0/3] ASoC: fsl_esai: Add support for imx8qm Shengjiu Wang
2020-05-01 8:12 ` [PATCH 1/3] ASoC: fsl_esai: introduce SoC specific data Shengjiu Wang
2020-05-04 21:39 ` Nicolin Chen [this message]
2020-05-01 8:12 ` [PATCH 2/3] ASoC: fsl_esai: Add support for imx8qm Shengjiu Wang
2020-05-01 10:21 ` Mark Brown
2020-05-06 2:33 ` Shengjiu Wang
2020-05-12 2:48 ` Shengjiu Wang
2020-05-12 12:38 ` Mark Brown
2020-05-15 10:01 ` Shengjiu Wang
2020-05-01 8:12 ` [PATCH 3/3] ASoC: fsl_esai: Add new compatible string " Shengjiu Wang
2020-05-12 16:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504213905.GA21292@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).