devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244@gmail.com>
To: heiko@sntech.de
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328
Date: Tue,  5 May 2020 19:02:27 +0200	[thread overview]
Message-ID: <20200505170227.6503-1-jbx6244@gmail.com> (raw)
In-Reply-To: <20200321215423.12176-1-jbx6244@gmail.com>

A test with the command below gives for example this error:

arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: phy@0:
'#phy-cells' is a required property

The phy nodename is normally used by a phy-handle.
This node is however compatible with
"ethernet-phy-id1234.d400", "ethernet-phy-ieee802.3-c22"
which is just been added to 'ethernet-phy.yaml'.
So change nodename to 'ethernet-phy' for which '#phy-cells'
is not a required property

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Changes v2:
  Reword commit message in the same way as in the patches for
  'rk3228-evb.dts' and 'rk3229-xms6.dts'
  that are already aproved.

  Patch 2-6 of version 1 unchanged.
---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 931a9279e..fdf0e1b26 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -935,7 +935,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			phy: phy@0 {
+			phy: ethernet-phy@0 {
 				compatible = "ethernet-phy-id1234.d400", "ethernet-phy-ieee802.3-c22";
 				reg = <0>;
 				clocks = <&cru SCLK_MAC2PHY_OUT>;
-- 
2.11.0


  parent reply	other threads:[~2020-05-05 17:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
2020-03-21 21:54 ` [PATCH 2/6] arm64: dts: rockchip: fix rtl8211f nodename for rk3328 Beelink A1 Johan Jonker
2020-03-21 21:54 ` [PATCH 3/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-nanopi4 Johan Jonker
2020-03-21 21:54 ` [PATCH 4/6] arm64: dts: rockchip: fix &pinctrl phy sub " Johan Jonker
2020-03-21 21:54 ` [PATCH 5/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-orangepi Johan Jonker
2020-03-21 21:54 ` [PATCH 6/6] arm64: dts: rockchip: fix &pinctrl phy sub " Johan Jonker
2020-05-05 17:02 ` Johan Jonker [this message]
2020-05-18 22:28   ` [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328 Heiko Stuebner
2020-05-18 22:27 ` [PATCH 1/6] " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505170227.6503-1-jbx6244@gmail.com \
    --to=jbx6244@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).