From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 556AFC47257 for ; Wed, 6 May 2020 19:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37E0524959 for ; Wed, 6 May 2020 19:25:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Oy6t/RM9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728986AbgEFTZx (ORCPT ); Wed, 6 May 2020 15:25:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729062AbgEFTZv (ORCPT ); Wed, 6 May 2020 15:25:51 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8F0C061A10 for ; Wed, 6 May 2020 12:25:50 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id 207so1564372pgc.6 for ; Wed, 06 May 2020 12:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CwlP6EYHN6g+DNT34PQdILeoztGCENWoPR/CrDmj7cM=; b=Oy6t/RM9X407g9VMd/oZUFCv1R2vqkGVDxiJqcLgBRjg6gGsAhHbK5XNjSaZDrGR6i hcvJ0DAA6cLxzphFrdMOSLz1Thq0IJ6BUo4ADyQqma2/3XAmeQfPKXE3JtmPTSVbT1tC c0QAA53U7nJEzR6q/TNrMoYN80r0hy3OKaacY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CwlP6EYHN6g+DNT34PQdILeoztGCENWoPR/CrDmj7cM=; b=kZ6JrFAoLLBgWPLgZiBEUD9hD4T8DlcRj/DPrv4wdOzKF5YiQppzUW8F5khoIejxAK e/3Ajr5krEtuOjQCfLgW+0l7qoqEbS/tM1MXQNGGbHp0yW+dlakOsm8RgvoIs/aZsDZo 7uhVLUKDmJV4vkmMApZOB8i4Svi6AGAQuhN2io4qvqId3bFYGbiJJin0+utgdPNr8kBJ pVKAfS0/k/8J6LgQaYgxfZnsAqfOjKgTCJ6d8hONvZpXgEWENT8LGN3S6Zp396xL4xF7 KzyHufuuSL3KL5LpnJA0rOwVHkHX59A2JgfyGmdNc9Hm5OGr8uzs8STXk/N0rOdteo1h B4gw== X-Gm-Message-State: AGi0PuY9ux1HVoCqbrlwpIq0EdxDySETa6lowGo/XrTJs+8V3Y3yV5Sy ftKlyxqtUAWeB3f/7Fe1/Egzjw== X-Google-Smtp-Source: APiQypLUKuBtus1IitoTsBLnaDmsbHfvQH+D98llQB+TKmq2UsX5RoGXA/K8c4olMhXO8vUm9fsIvw== X-Received: by 2002:a63:3d43:: with SMTP id k64mr8230250pga.150.1588793149484; Wed, 06 May 2020 12:25:49 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id l6sm2597373pfl.128.2020.05.06.12.25.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2020 12:25:48 -0700 (PDT) Date: Wed, 6 May 2020 12:25:47 -0700 From: Matthias Kaehlcke To: Harigovindan P Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, hoegsberg@chromium.org, kalyan_t@codeaurora.org, nganji@codeaurora.org Subject: Re: [v2] arm64: dts: sc7180: add dsi controller and phy entries for idp dts Message-ID: <20200506192547.GY4525@google.com> References: <20200211113735.6840-1-harigovi@codeaurora.org> <20200214184937.GA15781@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200214184937.GA15781@google.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 14, 2020 at 10:49:37AM -0800, Matthias Kaehlcke wrote: > On Tue, Feb 11, 2020 at 05:07:35PM +0530, Harigovindan P wrote: > > > subject: arm64: dts: sc7180: add dsi controller and phy entries for idp dts > > nit: 'dts' at the end is redundant, the prefixes make it clear that this > is about DT entries. > > Also the message isn't really concise. The main entries for the DSI > controller and the PHY are in sc7180.dtsi. I would suggest to drop > any mentions of DSI controller and PHYs, and just say something like > 'Add nodes for IDP display'. In the body you could mention that the > display is the Visionox RM69299. > > > Adding dsi controller and phy entries for idp dt. > > > > Signed-off-by: Harigovindan P > > --- > > > > Changes in v1: > > - Added dsi controller and dsi phy entries for idp dts > > Changes in v1 is pointless, it's the first patch > > > Changes in v2: > > - Adding dependency patchwork series > > - Removing suspend configuration > > - Adding blank before curly brace > > > > This patch depends on following patchwork series: > > > > https://patchwork.kernel.org/patch/11364687/ > > https://patchwork.kernel.org/patch/11366303/ > > > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 55 +++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 388f50ad4fde..6ccf8c3603ab 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -7,6 +7,7 @@ > > > > /dts-v1/; > > > > +#include > > #include > > #include "sc7180.dtsi" > > #include "pm6150.dtsi" > > @@ -232,6 +233,49 @@ vreg_bob: bob { > > }; > > }; > > > > +&dsi0 { > > + status = "okay"; > > + > > + vdda-supply = <&vreg_l3c_1p2>; > > + > > + panel@0 { > > + compatible = "visionox,rm69299-1080p-display"; > > + reg = <0>; > > + > > + vdda-supply = <&vreg_l8c_1p8>; > > + vdd3p3-supply = <&vreg_l18a_2p8>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&disp_pins>; > > + > > + reset-gpios = <&pm6150l_gpio 3 GPIO_ACTIVE_HIGH>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + port@0 { > > + reg = <0>; > > + panel0_in: endpoint { > > + remote-endpoint = <&dsi0_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + ports { > > + port@1 { > > + endpoint { > > + remote-endpoint = <&panel0_in>; > > + data-lanes = <0 1 2 3>; > > + }; > > + }; > > + }; > > +}; > > + > > +&dsi_phy { > > + status = "okay"; > > +}; > > + > > &qspi { > > status = "okay"; > > pinctrl-names = "default"; > > @@ -289,6 +333,17 @@ &usb_1_qmpphy { > > > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > +&pm6150l_gpio { > > + disp_pins: disp-pins { > > + pins = "gpio3"; > > + function = "func1"; > > + qcom,drive-strength = <2>; > > + power-source = <0>; > > + bias-disable; > > + output-low; > > + }; > > +}; > > + > > &qspi_clk { > > pinconf { > > pins = "gpio63"; > > To get the display actually to work you also need this: > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 88919da1510b03..fdbcb56dfa81f9 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -276,6 +276,14 @@ > status = "okay"; > }; > > +&mdp { > + status = "okay"; > +}; > + > +&mdss { > + status = "okay"; > +}; > + > &qspi { > status = "okay"; > pinctrl-names = "default"; > > Maybe just add this to this patch? ping the display driver landed in drm-misc, but this patch still needs a respin.