From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD76C54E49 for ; Thu, 7 May 2020 04:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19A2D2082E for ; Thu, 7 May 2020 04:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L9JVeMJq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725834AbgEGEXW (ORCPT ); Thu, 7 May 2020 00:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725802AbgEGEXW (ORCPT ); Thu, 7 May 2020 00:23:22 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25DD6C061A0F; Wed, 6 May 2020 21:23:22 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id u10so1545950pls.8; Wed, 06 May 2020 21:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6G+6eM+WUd8jnoXez9hLJ5VPYRmDs4q7SM6DwmQSnA4=; b=L9JVeMJqgEQBzurgIqXdi3L9TtEo0pjexujwUfiAFa1SI6mhcCSpGS/l35i+s6+o74 2fQykf8CgPob+2Ha8noFcvBGOyYTRa3SxkLPC3tuqNh9nNQTk8tvBGykuRKpvRqNjbbQ AbBEfqHEbCSbpKO0KTyk/2E5t907BFOMx+a8Te+gtqMD99dg6iNafZoyoBAON3J2meKl gPi2rZYIhTuEnzLjXH8yDRsKMv4h/PsufacBHXtr7D3ivThthxaRlG+IfI3VB/sfmOBj 2Cmbm8iellbywzHSGnlmK+T+7VmCaPAljBChuo6geyQjReshvrIKCjuEGsv4hU0tu1p+ oWyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6G+6eM+WUd8jnoXez9hLJ5VPYRmDs4q7SM6DwmQSnA4=; b=NcKUH67/gfZZnhAsYHyvTEqJq9rLwVuC5XzFhFkodeIDm8fSTjY93Pzl3Xn+qxljq2 NB8QwG7GuoLzXeQoEVTxLeHLOPs0X/95N/RxOyfTVINfqRYEnmkmNFIBVASMSxvB+Fel kzutREfIaE1qii43ImLV3UViMQMdh8AUQX7EwLeYOgeQtdxdY5Jik89yoZ016uhIsDJR CExVs8TadJYqpePEi3JK4xV087GyKQMgpReoMKjL+knYwENxw3CoxS+HM179woaNI21U aShmsgEhfhRgyVl1IQz3gCRzlGOsJl3hOkVk2qwQ1bm6a+0VJN6EiJ3Oq1+354BNfYeb kbag== X-Gm-Message-State: AGi0PuadYi09YDNuedcTz4eRndwV2L+PW332nTyNRg1NzW06eQM3mB1T Z+2fhu6g0Bxc+ky1z9frI+s= X-Google-Smtp-Source: APiQypKfVQJJDaMh/+EdjgY2icxQ8eu1eW9hG6nbY1dwgWodpmUB8r4EHl2DChcWe82TXYKcYbfrUw== X-Received: by 2002:a17:90a:32ea:: with SMTP id l97mr13148734pjb.50.1588825401246; Wed, 06 May 2020 21:23:21 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3c2a:73a9:c2cf:7f45]) by smtp.gmail.com with ESMTPSA id x7sm3461022pfj.122.2020.05.06.21.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 21:23:20 -0700 (PDT) Date: Wed, 6 May 2020 21:23:18 -0700 From: Dmitry Torokhov To: Jonathan Bakker Cc: Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Rob Herring , linux-iio , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Kate Stewart , Greg KH , Thomas Gleixner , Linux Input Subject: Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support Message-ID: <20200507042318.GD89269@dtor-ws> References: <20200503172206.13782-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 06, 2020 at 08:46:12PM -0700, Jonathan Bakker wrote: > Hi Linus, > > On 2020-05-06 5:46 a.m., Linus Walleij wrote: > > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > > > >> The bma180 IIO driver has been extended for support for bma023. > >> However, this could cause conflicts with this driver. Since some > >> setups may depend upon the evdev setup, disable support in this > >> driver for the bma023 only when the IIO driver is being built. > >> > >> Signed-off-by: Jonathan Bakker > > > > I would just fix this with KConfig instead, like add mutually > > exclusive depends on these two drivers. > > > > Set this input driver as: > > depends on BMA180=n > > > > And the IIO driver as: > > depends on INPUT_BMA150=n > > > > It's a rough measure but this input driver should anyway > > go away. Isn't the driver handle more than bma023? I see bma150 and smb380 ID's. If we go Kconfig route we will be disabling it for them as well when IIO driver is enabled. > > > > Ok, sounds good to me. If I include a patch removing the input > driver, can I just drop this patch entirely? > > The only in-tree user of the input driver (based on i2c ids) is Intel > Mid. Not sure what the kernel policy on dropping drivers is. Do we still support this platform? I'd start there. Thanks. -- Dmitry