From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: c630: Make i2c devices active high
Date: Wed, 6 May 2020 22:40:33 -0700 [thread overview]
Message-ID: <20200507054033.GD3236072@builder.lan> (raw)
In-Reply-To: <20200406052447.105513-1-bjorn.andersson@linaro.org>
On Sun 05 Apr 22:24 PDT 2020, Bjorn Andersson wrote:
> The two i2c hid devices on i2c3 are supposed to have interrupts
> triggered active high, update this.
>
While this is what the DSDT says, keeping it as RISING avoids occasional
drops of keyboard entries. So let's ignore this for now.
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index be6635068dc3..d4cdde496b74 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -338,7 +338,7 @@ hid@15 {
> reg = <0x15>;
> hid-descr-addr = <0x1>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> hid@2c {
> @@ -346,7 +346,7 @@ hid@2c {
> reg = <0x2c>;
> hid-descr-addr = <0x20>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
>
> pinctrl-names = "default";
> pinctrl-0 = <&i2c2_hid_active>;
> --
> 2.26.0
>
prev parent reply other threads:[~2020-05-07 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 5:24 [PATCH] arm64: dts: qcom: c630: Make i2c devices active high Bjorn Andersson
2020-05-07 5:40 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507054033.GD3236072@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).