* [PATCH] arm64: dts: qcom: c630: Make i2c devices active high
@ 2020-04-06 5:24 Bjorn Andersson
2020-05-07 5:40 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2020-04-06 5:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel
The two i2c hid devices on i2c3 are supposed to have interrupts
triggered active high, update this.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index be6635068dc3..d4cdde496b74 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -338,7 +338,7 @@ hid@15 {
reg = <0x15>;
hid-descr-addr = <0x1>;
- interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
+ interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
};
hid@2c {
@@ -346,7 +346,7 @@ hid@2c {
reg = <0x2c>;
hid-descr-addr = <0x20>;
- interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
+ interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&i2c2_hid_active>;
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: qcom: c630: Make i2c devices active high
2020-04-06 5:24 [PATCH] arm64: dts: qcom: c630: Make i2c devices active high Bjorn Andersson
@ 2020-05-07 5:40 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-05-07 5:40 UTC (permalink / raw)
To: Andy Gross, Rob Herring; +Cc: linux-arm-msm, devicetree, linux-kernel
On Sun 05 Apr 22:24 PDT 2020, Bjorn Andersson wrote:
> The two i2c hid devices on i2c3 are supposed to have interrupts
> triggered active high, update this.
>
While this is what the DSDT says, keeping it as RISING avoids occasional
drops of keyboard entries. So let's ignore this for now.
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index be6635068dc3..d4cdde496b74 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -338,7 +338,7 @@ hid@15 {
> reg = <0x15>;
> hid-descr-addr = <0x1>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> hid@2c {
> @@ -346,7 +346,7 @@ hid@2c {
> reg = <0x2c>;
> hid-descr-addr = <0x20>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
>
> pinctrl-names = "default";
> pinctrl-0 = <&i2c2_hid_active>;
> --
> 2.26.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-07 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-06 5:24 [PATCH] arm64: dts: qcom: c630: Make i2c devices active high Bjorn Andersson
2020-05-07 5:40 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).