From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E347C38A24 for ; Thu, 7 May 2020 06:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65F032080D for ; Thu, 7 May 2020 06:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588833708; bh=ZfGZjSQzlxql6JrfYK2CjpWc5gUaW3O8isNZHL1cHgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qtxhFC0JC2Alonhwc5uj/e5hI0bxhirJBVuRs2pF9AI7XNFaEShE9TU8X86gTr98P 1lYuONFavF+MczR7berXcpM71K2cJNgCQ4L8/tuLndbTAQJPiVED6DTsE4+o6cz3cd Q7iR3/MoJiAp8y931Nemk8HfYjCscDHqH3WPyVQU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbgEGGlr (ORCPT ); Thu, 7 May 2020 02:41:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:55574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbgEGGlr (ORCPT ); Thu, 7 May 2020 02:41:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9141F20753; Thu, 7 May 2020 06:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588833707; bh=ZfGZjSQzlxql6JrfYK2CjpWc5gUaW3O8isNZHL1cHgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M09WcW1KjQjAJdPTQm0zozAA6/w6JqJ+af+Z9XAf7SHLgvMuh64pWlYzK/VnpMS6I mP1uw8407EQPHb2GkFDezqjut6jLHEnsLov8p1RWeNzwruCy100T1i2lCe8MECNhi1 b2/yksuqVxBEj5B6xSJeLVCPdSnxRKp54DYlAR24= Date: Thu, 7 May 2020 08:41:45 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Alan Cooper , ": Linux Kernel Mailing List" , Alan Stern , BCM Kernel Feedback , DTML , Krzysztof Kozlowski , USB list , Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko Subject: Re: [PATCH v6 3/4] usb: ehci: Add new EHCI driver for Broadcom STB SoC's Message-ID: <20200507064145.GB777100@kroah.com> References: <20200430111258.6091-1-alcooperx@gmail.com> <20200430111258.6091-4-alcooperx@gmail.com> <20200505110036.GB93160@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 07, 2020 at 12:01:16AM +0300, Andy Shevchenko wrote: > On Wed, May 6, 2020 at 11:23 PM Alan Cooper wrote: > > On Tue, May 5, 2020 at 7:00 AM Greg Kroah-Hartman > > wrote: > > > On Thu, Apr 30, 2020 at 07:12:57AM -0400, Al Cooper wrote: > > ... > > > > > + /* Hook the hub control routine to work around a bug */ > > > > > > What bug? This feels wrong. > > > > The bug is explained in a comment above the ehci_brcm_hub_control() > > routine as follows: > > /* > > * ehci_brcm_hub_control > > * Intercept echi-hcd request to complete RESUME and align it to the start > > * of the next microframe. > > * If RESUME is complete too late in the microframe, host controller > > * detects babble on suspended port and resets the port afterwards. > > * This s/w workaround allows to avoid this problem. > > * See SWLINUX-1909 for more details > > */ > > I'll remove the internal bug tracking reference from the comment. > > I guess you may leave the internal bug reference. I can tell from my > experience that's hard to understand what was going on in the driver > in years perspective. It will help whoever in this company have a > chance to look after the driver. "internal bug references" mean nothing to the 99% of the people that can see this. Document the heck out of what this is instead please. greg k-h