From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743ADC38A24 for ; Thu, 7 May 2020 14:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BC342082E for ; Thu, 7 May 2020 14:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbgEGOMT (ORCPT ); Thu, 7 May 2020 10:12:19 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:39769 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbgEGOMS (ORCPT ); Thu, 7 May 2020 10:12:18 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 0FDB2200004; Thu, 7 May 2020 14:12:13 +0000 (UTC) Date: Thu, 7 May 2020 16:12:12 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Rob Herring , Mark Rutland , , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , , Thomas Petazzoni , Michal Simek , Naga Sureshkumar Relli Subject: Re: [PATCH v3 4/8] mtd: rawnand: Add nand_extract_bits() Message-ID: <20200507161212.40551eb5@xps13> In-Reply-To: <20200507134959.38bbcdc4@collabora.com> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-5-miquel.raynal@bootlin.com> <20200507134959.38bbcdc4@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Boris Brezillon wrote on Thu, 7 May 2020 13:49:59 +0200: > On Thu, 7 May 2020 13:00:30 +0200 > Miquel Raynal wrote: > > > There are cases where ECC bytes are not byte-aligned. Indeed, BCH > > implies using a number of ECC bits, which are not always a multiple of > > 8. We then need a helper like nand_extract_bits() to extract these > > syndromes from a buffer. > > Do you plan to send a patch to make the GPMI driver use this helper? I will have a look at it.