From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330D8C38A24 for ; Thu, 7 May 2020 15:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18E3E208D6 for ; Thu, 7 May 2020 15:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727955AbgEGPNQ convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2020 11:13:16 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:36305 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbgEGPNP (ORCPT ); Thu, 7 May 2020 11:13:15 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7996520000A; Thu, 7 May 2020 15:13:12 +0000 (UTC) Date: Thu, 7 May 2020 17:13:11 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Mark Rutland , Rob Herring , , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , , Thomas Petazzoni , Michal Simek , Naga Sureshkumar Relli Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507171311.7669d0db@xps13> In-Reply-To: <20200507141103.0c241877@collabora.com> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> <20200507141103.0c241877@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, Boris Brezillon wrote on Thu, 7 May 2020 14:11:03 +0200: > On Thu, 7 May 2020 13:00:33 +0200 > Miquel Raynal wrote: > > > > + > > +static void anfc_chips_cleanup(struct arasan_nfc *nfc) > > +{ > > + struct anand *anand, *tmp; > > + > > + list_for_each_entry_safe(anand, tmp, &nfc->chips, node) { > > + nand_release(&anand->chip); > > ret = mtd_device_unregister(nand_to_mtd(&anand->chip)); > WARN_ON(ret); > nand_cleanup(&anand->chip); > > Or maybe add this WARN_ON() to nand_release() so we don't have to ask > people to use mtd_device_unregister() + nand_cleanup(). I don't get your point here? I'm not against adding a warn_on between both functions but it's not related to this driver? > We really > should fix that at some point (allocate nand_chip and mtd_info > separately and leave a dummy mtd_info object with all hooks returning > ENODEV when the unregister fails). Yes, we should fix that. > > > + list_del(&anand->node); > > + } > > +} Thanks, Miquèl