From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FE6C38A24 for ; Thu, 7 May 2020 15:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E303B207DD for ; Thu, 7 May 2020 15:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbgEGPY7 convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2020 11:24:59 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:39856 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgEGPY7 (ORCPT ); Thu, 7 May 2020 11:24:59 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id DECBF2A204A; Thu, 7 May 2020 16:24:55 +0100 (BST) Date: Thu, 7 May 2020 17:24:53 +0200 From: Boris Brezillon To: Miquel Raynal , Vignesh Raghavendra Cc: Mark Rutland , Rob Herring , , Richard Weinberger , Tudor Ambarus , , Thomas Petazzoni , Michal Simek , Naga Sureshkumar Relli Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507172453.15a03574@collabora.com> In-Reply-To: <20200507171311.7669d0db@xps13> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> <20200507141103.0c241877@collabora.com> <20200507171311.7669d0db@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 7 May 2020 17:13:11 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Thu, 7 May > 2020 14:11:03 +0200: > > > On Thu, 7 May 2020 13:00:33 +0200 > > Miquel Raynal wrote: > > > > > > > + > > > +static void anfc_chips_cleanup(struct arasan_nfc *nfc) > > > +{ > > > + struct anand *anand, *tmp; > > > + > > > + list_for_each_entry_safe(anand, tmp, &nfc->chips, node) { > > > + nand_release(&anand->chip); > > > > ret = mtd_device_unregister(nand_to_mtd(&anand->chip)); > > WARN_ON(ret); > > nand_cleanup(&anand->chip); > > > > Or maybe add this WARN_ON() to nand_release() so we don't have to ask > > people to use mtd_device_unregister() + nand_cleanup(). > > I don't get your point here? I'm not against adding a warn_on between > both functions but it's not related to this driver? We've asked people to not call nand_release() but instead call mtd_device_unregister()+nand_cleanup(), which is not done here. My point is, if even us can't get it right, maybe it's a sign we should instead patch nand_release() to do the right thing. > > > We really > > should fix that at some point (allocate nand_chip and mtd_info > > separately and leave a dummy mtd_info object with all hooks returning > > ENODEV when the unregister fails). > > Yes, we should fix that. > > > > > > + list_del(&anand->node); > > > + } > > > +} > > Thanks, > Miquèl