Re: [PATCH v2 14/20] mips: Use offset-sized IO-mem accessors in CPS debug printout

Serge Semin
2020-05-06T19:52:55Z

Hi

On Wed, May 06, 2020 at 09:16:24PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 05/06/2020 08:42 PM, Sergey.Semin@baikalelectronics.ru wrote:
>
> > From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > Similar to commit 8e5c62e38a88 ("mips: early_printk_8250: Use offset-sized
> > IO-mem accessors") the IO-memory might require to use a proper load/store
> > instructions (like Bailal-T1 IO-memory). To fix the cps-vec UART debug
>
> Baikal? :-)

Yeah, thanks.)

>
> > printout lets use the memory access instructions in accordance with the
> > UART registers offset config specified at boot time.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: linux-pm@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> >
> > ---
> > There might be another problem in cps-vec-ns16550.S connected with the
> > difference in CPU/devices endinanness on some platforms. But there is
>
> Endianness.

Ah, this won't get into the commit message anyway. But thanks for noticing.)

-Sergey

>
> > no such for Baikal-T1 SoC.
> [...]
>
> MBR, Sergei