From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86B9C38A2A for ; Thu, 7 May 2020 19:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 891B7208E4 for ; Thu, 7 May 2020 19:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbgEGT6R (ORCPT ); Thu, 7 May 2020 15:58:17 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:42078 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgEGT6R (ORCPT ); Thu, 7 May 2020 15:58:17 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 32D9380520; Thu, 7 May 2020 21:58:14 +0200 (CEST) Date: Thu, 7 May 2020 21:58:12 +0200 From: Sam Ravnborg To: Konrad Dybcio Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v4 PATCH 0/2] Add support for ASUS Z00T TM5P5 NT35596 panel Message-ID: <20200507195812.GB17398@ravnborg.org> References: <20200506210957.344590-1-konradybcio@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506210957.344590-1-konradybcio@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=m4rRuWqDM7RkiSaC_YMA:9 a=CjuIK1q_8ugA:10 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Konrad. On Wed, May 06, 2020 at 11:09:54PM +0200, Konrad Dybcio wrote: > changes since v3: > - fix dt-bindings issue > > changes since v2: > - fix Kconfig indentation > > changes since v1: > - make `backlight_properties props` constant > - a couple of line breaks > - change name and compatible to reflect ASUS being the vendor > - remove a redundant TODO > > Konrad Dybcio (2): > drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver > dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel > compatible Thanks, applied in the reverse order to have the binding before the driver. Fixed a few checkpatch warnings while applying. We use --strict for code in drivers/gpu/* Sam > > .../panel/asus,z00t-tm5p5-nt35596.yaml | 56 +++ > drivers/gpu/drm/panel/Kconfig | 10 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-asus-z00t-tm5p5-n35596.c | 367 ++++++++++++++++++ > 4 files changed, 434 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml > create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c > > -- > 2.26.2