From: Andrew Lunn <andrew@lunn.ch>
To: Hui Song <hui.song_1@nxp.com>
Cc: u-boot@linux.nxdi.nxp.com, jiafei.pan@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 2/3] armv8: gpio: add gpio feature
Date: Sat, 9 May 2020 17:33:15 +0200 [thread overview]
Message-ID: <20200509153315.GR208718@lunn.ch> (raw)
In-Reply-To: <20200509103956.26038-3-hui.song_1@nxp.com> <20200509103956.26038-2-hui.song_1@nxp.com>
On Sat, May 09, 2020 at 06:39:55PM +0800, Hui Song wrote:
> From: "hui.song" <hui.song_1@nxp.com>
>
> add one struct mpc8xxx_gpio_plat to enable gpio feature.
>
> Signed-off-by: hui.song <hui.song_1@nxp.com>
> ---
> .../include/asm/arch-fsl-layerscape/gpio.h | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/gpio.h
>
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/gpio.h b/arch/arm/include/asm/arch-fsl-layerscape/gpio.h
> new file mode 100644
> index 0000000000..d8dd750a72
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/gpio.h
> @@ -0,0 +1,22 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2014 Freescale Semiconductor, Inc.
> + */
> +
> +/*
> + * Dummy header file to enable CONFIG_OF_CONTROL.
> + * If CONFIG_OF_CONTROL is enabled, lib/fdtdec.c is compiled.
> + * It includes <asm/arch/gpio.h> via <asm/gpio.h>, so those SoCs that enable
> + * OF_CONTROL must have arch/gpio.h.
> + */
This does not seem right. You would expect each sub arch to have a
subdirectory in arch/arm/include/asm/ when in fact none do.
Andrew
next prev parent reply other threads:[~2020-05-09 15:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 10:39 [PATCH v1 1/3] gpio: mpc8xxx: support fsl-layerscape platform Hui Song
2020-05-09 10:39 ` [PATCH v1 2/3] armv8: gpio: add gpio feature Hui Song
2020-05-09 15:33 ` Andrew Lunn [this message]
2020-05-09 17:27 ` Russell King - ARM Linux admin
2020-05-09 18:04 ` Amit Tomer
2020-05-09 18:18 ` Russell King - ARM Linux admin
2020-05-09 18:26 ` Russell King - ARM Linux admin
2020-05-09 18:34 ` Amit Tomer
2020-05-09 10:39 ` [PATCH v1 3/3] dm: armv8: gpio: include <asm/arch/gpio.h> for fsl-layerscape Hui Song
2020-05-09 15:24 ` [PATCH v1 1/3] gpio: mpc8xxx: support fsl-layerscape platform Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2020-05-09 10:35 Hui Song
2020-05-09 10:35 ` [PATCH v1 2/3] armv8: gpio: add gpio feature Hui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509153315.GR208718@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=hui.song_1@nxp.com \
--cc=jiafei.pan@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u-boot@linux.nxdi.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).