From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 085BCC47255 for ; Mon, 11 May 2020 19:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9037206DB for ; Mon, 11 May 2020 19:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729523AbgEKTyl (ORCPT ); Mon, 11 May 2020 15:54:41 -0400 Received: from mga07.intel.com ([134.134.136.100]:53672 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbgEKTyl (ORCPT ); Mon, 11 May 2020 15:54:41 -0400 IronPort-SDR: 9QS6IqBZgzmK2xr3peMXjjFwHGwjIIq7iwSlkPvqglCyjzDAmCc99QZYl/ajzxT6ZID9Ic/WiW fzHQEiCNFP7g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 12:54:40 -0700 IronPort-SDR: nrkVhs2KY64uvbGWb8TbDdcpt1XqGWxWNDd41wC2FKPz9dUaJM9u6VAMspAPx6nHD6QH2LMvZ+ w72qZcPRYfEQ== X-IronPort-AV: E=Sophos;i="5.73,381,1583222400"; d="scan'208";a="297792634" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 12:54:36 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 379F6204C7; Mon, 11 May 2020 22:54:34 +0300 (EEST) Date: Mon, 11 May 2020 22:54:34 +0300 From: Sakari Ailus To: Rob Herring Cc: Dongchun Zhu , linus.walleij@linaro.org, bgolaszewski@baylibre.com, mchehab@kernel.org, andriy.shevchenko@linux.intel.com, mark.rutland@arm.com, drinkcat@chromium.org, tfiga@chromium.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, louis.kuo@mediatek.com, shengnan.wang@mediatek.com Subject: Re: [V8, 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20200511195434.GG11272@paasikivi.fi.intel.com> References: <20200509080627.23222-1-dongchun.zhu@mediatek.com> <20200509080627.23222-2-dongchun.zhu@mediatek.com> <20200511160207.GA32476@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511160207.GA32476@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Mon, May 11, 2020 at 11:02:07AM -0500, Rob Herring wrote: > On Sat, May 09, 2020 at 04:06:26PM +0800, Dongchun Zhu wrote: ... > > + properties: > > + endpoint: > > + type: object > > + > > + properties: > > + data-lanes: > > + description: |- > > + The driver only supports 1-lane operation. > > What the driver supports is not relevant. > > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + > > + clock-noncontinuous: > > + type: boolean > > + description: |- > > + MIPI CSI-2 clock is non-continuous if this property is present, > > + otherwise it's continuous. > > Assume this has a common definition, so just need: > > clock-noncontinuous: true > ... > > + data-lanes = <1>; > > This doesn't match the schema which says this should be 4 entries. I believe the intent has been to say there would be 1, 2, 3 or 4 entries --- i.e. the number of lanes. -- Kind regards, Sakari Ailus