From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Rob Herring <robh@kernel.org>
Cc: <lee.jones@linaro.org>, <broonie@kernel.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<jdelvare@suse.com>, <linux@roeck-us.net>,
<linus.walleij@linaro.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 5/5] mfd: lochnagar: Move binding over to dtschema
Date: Tue, 12 May 2020 15:06:36 +0000 [thread overview]
Message-ID: <20200512150636.GD71940@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20200512134949.GA14057@bogus>
On Tue, May 12, 2020 at 08:49:49AM -0500, Rob Herring wrote:
> On Mon, May 04, 2020 at 04:47:57PM +0100, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> >
> > Changes since v1:
> > - Removed contains on the compatible
> > - Moved all sub-nodes into here directly only using $ref for properties
> > - As the regulator binding only contained subnodes that file is now deleted
> > - Removed some pointless descriptions
> >
> > A little nervous about the amount of clock and regulator stuff this
> > pulls into the MFD file, any comments on that welcome? Would it be worth
> > looking into something along the lines of the definitions stuff to keep
> > some of that out in the clock and regulator bindings?
>
> It's fine like this. Other than my comments on patch 3, looks fine.
> Respin and I'll apply.
>
Groovy thanks for the reviews.
Thanks,
Charles
prev parent reply other threads:[~2020-05-12 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:47 [PATCH v2 1/5] hwmon: lochnagar: Move binding over to dtschema Charles Keepax
2020-05-04 15:47 ` [PATCH v2 2/5] ASoC: " Charles Keepax
2020-05-04 15:47 ` [PATCH v2 3/5] pinctrl: " Charles Keepax
2020-05-12 13:06 ` Linus Walleij
2020-05-12 13:33 ` Rob Herring
2020-05-12 13:44 ` Rob Herring
2020-05-04 15:47 ` [PATCH v2 4/5] clk: " Charles Keepax
2020-05-04 15:47 ` [PATCH v2 5/5] mfd: " Charles Keepax
2020-05-12 13:49 ` Rob Herring
2020-05-12 15:06 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512150636.GD71940@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).