Re: [PATCH v6 2/5] PCI: Add Loongson PCI Controller support

Jiaxun Yang
2020-04-27T06:46:37Z

On Mon, 27 Apr 2020 14:29:34 +0800
Huacai Chen <chenhc@lemote.com> wrote:

> Hi, Jiaxun,
>
> On Mon, Apr 27, 2020 at 2:06 PM Jiaxun Yang <jiaxun.yang@flygoat.com>
> wrote:
> >
> > This controller can be found on Loongson-2K SoC, Loongson-3
> > systems with RS780E/LS7A PCH.
> >
> > The RS780E part of code was previously located at
> > arch/mips/pci/ops-loongson3.c and now it can use generic PCI
> > driver implementation.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >
> > --
> > v2:
> > - Clean up according to rob's suggestions
> > - Claim that it can't work as a module
> > v3:
> > - Fix a typo
> > v4:
> > - More clean-ups: Drop flag check, use devfn
> > ---
> > drivers/pci/controller/Kconfig | 10 +
> > drivers/pci/controller/Makefile | 1 +
> > drivers/pci/controller/pci-loongson.c | 251

[...]

> > +static const struct of_device_id loongson_pci_of_match[] = {
> > + { .compatible = "loongson,rs780e-pci",
> > + .data = (void *)(FLAG_CFG0), },
> > + { .compatible = "loongson,ls2k-pci",
> > + .data = (void *)(FLAG_CFG0 | FLAG_CFG1 |
> > FLAG_DEV_FIX), },
> > + { .compatible = "loongson,ls7a-pci",
> > + .data = (void *)(FLAG_CFG0 | FLAG_CFG1 |
> > FLAG_DEV_FIX), },
> I suggest to use alpha-betical order here: ls2k, ls7a and rs780 at
> last.

Thanks for pointing out this minor issue.
I put rs780e at first at it appears to be the first system using this
driver.
If there is no more review suggestion I'll send out next revision very
soon.

[...]

--
Jiaxun Yang