From: Rob Herring <robh@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-clk@vger.kernel.org, aford@beaconembedded.com,
charles.stevens@logicpd.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] clk: vc5: Enable addition output configurations of the Versaclock
Date: Tue, 12 May 2020 17:05:37 -0500 [thread overview]
Message-ID: <20200512220537.GA14318@bogus> (raw)
In-Reply-To: <20200502122126.188001-2-aford173@gmail.com>
On Sat, May 02, 2020 at 07:21:25AM -0500, Adam Ford wrote:
> The existing driver is expecting the Versaclock to be pre-programmed,
> and only sets the output frequency. Unfortunately, not all devices
> are pre-programmed, and the Versaclock chip has more options beyond
> just the frequency.
>
> This patch enables the following additional features:
>
> - Programmable voltage: 1.8V, 2.5V, or 3.3V
> - Slew Percentage of normal: 85%, 90%, or 100%
> - Output Type: LVPECL, CMOS, HCSL, or LVDS
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> diff --git a/include/dt-bindings/clk/versaclock.h b/include/dt-bindings/clk/versaclock.h
> new file mode 100644
> index 000000000000..c6a6a0946564
> --- /dev/null
> +++ b/include/dt-bindings/clk/versaclock.h
Belongs in binding patch.
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +/* This file defines field values used by the versaclock 6 family
> + * for defining output type
> + */
> +
> +#define VC5_LVPECL 0
> +#define VC5_CMOS 1
> +#define VC5_HCSL33 2
> +#define VC5_LVDS 3
> +#define VC5_CMOS2 4
> +#define VC5_CMOSD 5
> +#define VC5_HCSL25 6
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-05-12 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 12:21 [PATCH V2 1/3] clk: vc5: Allow Versaclock driver to support multiple instances Adam Ford
2020-05-02 12:21 ` [PATCH V2 2/3] clk: vc5: Enable addition output configurations of the Versaclock Adam Ford
2020-05-12 22:05 ` Rob Herring [this message]
2020-05-12 22:21 ` Adam Ford
2020-05-29 4:02 ` Stephen Boyd
2020-05-02 12:21 ` [PATCH V2 3/3] dt: Add additional option bindings for IDT VersaClock Adam Ford
2020-05-29 4:29 ` [PATCH V2 1/3] clk: vc5: Allow Versaclock driver to support multiple instances Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512220537.GA14318@bogus \
--to=robh@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=charles.stevens@logicpd.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).