From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE491CA90AF for ; Wed, 13 May 2020 14:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FF56204EA for ; Wed, 13 May 2020 14:21:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QxLceh/W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388818AbgEMOVx (ORCPT ); Wed, 13 May 2020 10:21:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733142AbgEMOVw (ORCPT ); Wed, 13 May 2020 10:21:52 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB727C061A0E for ; Wed, 13 May 2020 07:21:52 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id fu13so11040722pjb.5 for ; Wed, 13 May 2020 07:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RlT8e3GCcw8hqsPevwx5SIqz1Z9X5As8Uu5brShveGY=; b=QxLceh/WDthFGjTg4/6exTgHleziMeWKUUSJfvj/RtzIKlLnQApe+g4V+hjuaa1Ptp D1AYd9MsauMExL+1Z8/z/+5BoVGto5lXJMDUEKlWBRzB1pFyM978O2vmX12mDAMuTD+Z htCA7DVzxORVrTIu8CXpN6DiW/xa9toR47eNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RlT8e3GCcw8hqsPevwx5SIqz1Z9X5As8Uu5brShveGY=; b=iwcE+zq1jfDgOJbIbEK98OcLaJI6O7xMH12GcScp3q9QKnDnfRb/HNdKkWkMzjJQsf N+Tlx61RWdZv0lkdVcri5dtsC/w1j00pljaV5uKMihtQImXrb9ZwqnQsXeWJEhpELDne oEtFLqOHcZTySkSeYm4arnNhZ4KhVJX3bMXUkajXYmr6ayu+tFBttDhcyajeAOLxQl+R 3oNY+28BvVVVYvTCIeaXkZ+Wezn79KHme/hF68s7naEaDNgmsSgb2oija3tZHdLqsJoc +4XgVWCZNbRePokOMNzPbv/imYStGw/PQ7sm//RR+wl21uxlutdwMr7MwkjOL/Y9+16x m7Jw== X-Gm-Message-State: AGi0PuYhEpICjbr0N4s7+eoETB2sO4N2J9inpWHxL/nlOAsdtq+DFEz3 AUI+BW8eF6Iz+hXzgsIMOHGlKA== X-Google-Smtp-Source: APiQypJdzY+fA3+rJVRnMRvec4DRswjq8ep69zHO1V/o5zYGd3s+BVAqerFHF1mnq2G2/E61KFLc+w== X-Received: by 2002:a17:90b:30cb:: with SMTP id hi11mr34795324pjb.103.1589379712177; Wed, 13 May 2020 07:21:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g9sm13282143pgj.89.2020.05.13.07.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2020 07:21:51 -0700 (PDT) Date: Wed, 13 May 2020 07:21:50 -0700 From: Kees Cook To: Rob Herring Cc: Pavel Tatashin , jmorris@namei.org, sashal@kernel.org, linux-kernel@vger.kernel.org, pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, devicetree@vger.kernel.org Subject: Re: [PATCH v2 5/5] ramoops: add max_reason optional field to ramoops DT node Message-ID: <202005130719.D9252B3867@keescook> References: <20200505154510.93506-1-pasha.tatashin@soleen.com> <20200505154510.93506-6-pasha.tatashin@soleen.com> <20200513024230.GA3514@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513024230.GA3514@bogus> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 12, 2020 at 09:42:30PM -0500, Rob Herring wrote: > On Tue, May 05, 2020 at 11:45:10AM -0400, Pavel Tatashin wrote: > > Currently, it is possible to dump kmsges for panic, or oops. > > With max_reason it is possible to dump messages for other > > kmesg_dump events, for example reboot, halt, shutdown, kexec. > > > > Signed-off-by: Pavel Tatashin > > --- > > .../devicetree/bindings/reserved-memory/ramoops.txt | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt > > index 0eba562fe5c6..886cff15d822 100644 > > --- a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt > > +++ b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt > > @@ -30,7 +30,7 @@ Optional properties: > > - ecc-size: enables ECC support and specifies ECC buffer size in bytes > > (defaults to 0: no ECC) > > > > -- record-size: maximum size in bytes of each dump done on oops/panic > > +- record-size: maximum size in bytes of each kmsg dump. > > (defaults to 0: disabled) > > > > - console-size: size in bytes of log buffer reserved for kernel messages > > @@ -45,7 +45,13 @@ Optional properties: > > - unbuffered: if present, use unbuffered mappings to map the reserved region > > (defaults to buffered mappings) > > > > -- no-dump-oops: if present, only dump panics (defaults to panics and oops) > > +- max_reason: maximum reason for kmsg dump. Defaults to 2 (dump oops and > > max-reason Thanks! I caught this in later versions, so it's correct now. :) -Kees -- Kees Cook