Re: [PATCH 4/7] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC rtd1195 and rtd1295.

[Rob Herring <robh@kernel.org>]

On Thu, May 14, 2020 at 05:21:22PM +0800, TY Chang wrote:
> Add compatible string for RTD1195 and RTD1295.
> 
> Signed-off-by: TY Chang <tychang@realtek.com>
> ---
>  .../bindings/pinctrl/realtek,rtd-pinctrl.yaml | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/realtek,rtd-pinctrl.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd-pinctrl.yaml
> new file mode 100644
> index 000000000000..5af5fc8fe633
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd-pinctrl.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/realtek,rtd-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek DHC pin control
> +
> +maintainers:
> +  - Andreas Farber <afaerber@suse.de>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - realtek,rtd1195-iso-pinctrl
> +      - realtek,rtd1195-crt-pinctrl
> +      - realtek,rtd1295-iso-pinctrl
> +      - realtek,rtd1295-sb2-pinctrl
> +      - realtek,rtd1295-disp-pinctrl
> +      - realtek,rtd1295-cr-pinctrl
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    iso_pinctrl: pinctrl@300 {
> +        compatible = "realtek,rtd1195-iso-pinctrl";
> +        reg = <0x300 0x14>;

Aren't there child nodes with pin settings? They need to be documented.

> +    }
> +  - |
> +    crt_pinctrl: pinctrl@300 {
> +        compatible = "realtek,rtd1195-crt-pinctrl";
> +        reg = <0x300 0x78>;
> +    }
> +  - |
> +    iso_pinctrl: pinctrl@300 {
> +        compatible = "realtek,rtd1295-iso-pinctrl";
> +        reg = <0x300 0x24>;
> +    }
> +  - |
> +    sb2_pinctrl: pinctrl@900 {
> +        compatible = "realtek,rtd1295-sb2-pinctrl";
> +        reg = <0x900 0x100>;
> +    }
> +  - |
> +    disp_pinctrl: pinctrl@4d000 {
> +        compatible = "realtek,rtd1295-disp-pinctrl";
> +        reg = <0x4d000 0x100>;
> +    };
> +  - |
> +    cr_pinctrl: pinctrl@12600 {
> +        compatible = "realtek,rtd1295-cr-pinctrl";
> +        reg = <0x12600 0x100>;
> +    };
> +
> -- 
> 2.26.2
>