From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 850A2C433E0 for ; Mon, 18 May 2020 14:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 618F120657 for ; Mon, 18 May 2020 14:24:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="TNTTmdPi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbgEROYM (ORCPT ); Mon, 18 May 2020 10:24:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbgEROYI (ORCPT ); Mon, 18 May 2020 10:24:08 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37011C061A0C for ; Mon, 18 May 2020 07:24:08 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id a9so8221838lfb.8 for ; Mon, 18 May 2020 07:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=n1fBLRPhoaETkliq/A27B/1RTPiV9jHJlDqYtxK0Yw0=; b=TNTTmdPizHT9crmFFEjj9L02FrgJrG8L0bUlQVGrvvAH963M6bvF/nW2rf3Gp1o/73 k7PcRx0EdXy2xcLiIdONyHqqbStU4qU7eGASiXa25+hFP5vC30q6miUEVyYkY5KgvC4k /zGKHQZ/uiTrC2U46IjBHynwE2FG1JUVhlKwaCHi5/xLauPlJ/oD/8qqhhgew/Xrx2Q/ tzl1KqMCLYbSyeGRG1MkqowBeKyhVM/S47EHW7K9JlQyAGNH8j1DlvsN4FL9vrTV499o uJKlXDnE8hUNwBcGyAR0TgjgVM9GFlojBk/WbVgFVR5vEgAKK88vNPI5KG9TIpKxBixk 99tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n1fBLRPhoaETkliq/A27B/1RTPiV9jHJlDqYtxK0Yw0=; b=WrVD0w6puL5C7YixTCQ4DhWhUxQ4ENGzJcOPI5dEmQzIsuYVQIBoC95YLSLW2c8Por zSbfCEBF23ksLHlcRB95zPgmO4PXbAcLoyOuyuibemka9yKpw9/NpU0n1fysdIs06yPo mt6DefzNcYjTQAMg6iuZVzMI0+58/yAfrUIJw0banNPEuiubMH1skFu/YARMJH2iFEbt eY9hctNABSkJKh9ugPvkCuO1k5aDxiBOvih00S1ZvjDkDVIlqRmMvedQ0Zf6vhNPpp/L GANb74w8dJ9DSpPJQiV8MNc4saK04BfBOFEz+rLx3633lRCciy0EIw4+5iZwq0qQQvnc Tprg== X-Gm-Message-State: AOAM532YF8H9xtjBFyWrlkghxdOSN3U/g3wMMe42eHZo5uxl+H16t6hh xwExlegnNhCR9uSz5aQYvkjGjmjTDw/eVPDn2uU= X-Google-Smtp-Source: ABdhPJz1oUVBZQTXPnfWBabJX27Y9GJSHH/mmmmILTNHRuqsL7eQMEbJSFWn9U8RcWnQA/QURPYc0A== X-Received: by 2002:a19:4854:: with SMTP id v81mr7521098lfa.189.1589811846308; Mon, 18 May 2020 07:24:06 -0700 (PDT) Received: from x1 (i59F66838.versanet.de. [89.246.104.56]) by smtp.gmail.com with ESMTPSA id 3sm2581016lfq.55.2020.05.18.07.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 07:24:05 -0700 (PDT) Date: Mon, 18 May 2020 16:24:02 +0200 From: Drew Fustini To: Felipe Balbi Cc: Linus Walleij , Grygorii Strashko , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Rob Herring , Linux-OMAP , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Jason Kridner , Robert Nelson Subject: Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names Message-ID: <20200518142402.GB916914@x1> References: <20200508165821.GA14555@x1> <875zcty7tt.fsf@kernel.org> <87zha5whf4.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zha5whf4.fsf@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 18, 2020 at 03:34:23PM +0300, Felipe Balbi wrote: > Linus Walleij writes: > > > On Mon, May 18, 2020 at 10:18 AM Felipe Balbi wrote: > >> Linus Walleij writes: > >> >> gpiochip0 - 32 lines: > >> >> line 0: "ethernet" unused input active-high > >> >> line 1: "ethernet" unused input active-high > >> > > >> > Why are the ethernet lines not tagged with respective signal name > >> > when right below the SPI lines are explicitly tagged with > >> > sclk, cs0 etc? > >> > > >> > Ethernet is usually RGMII and has signal names like > >> > tx_clk, tx_d0, tx_en etc. > >> > > >> > Also some lines seem to be tagged with the pin number > >> > like P9_22, P2_21 below, it seems a bit inconsistent > >> > to have much information on some pins and very sketchy > >> > information on some. > >> > >> the pin names match the beagle bone documentation and would help users > >> figure out which pins on the expansion headers match to a gpio signal. Thank you for pointing this out. That is my goal with the line names. > > > > OK if it is how it looks in the documentation I agree that is what > > users need, maybe the documentation is confusing but there is not > > much to do about that. > > the board has two expansion headers, P1 and P2: > > https://github.com/beagleboard/pocketbeagle/wiki/System-Reference-Manual#531_Expansion_Headers > > Pins are always the pin number on the header, hence P2_21 and P1_10 and > so on. Just to clarify, the patch was for the BeagleBone {White,Green,Black} which have P8 and P9 headers. The PocketBeagle has lower pin count headers labeled P1 and P2. I do plan to submit a patch for am335x-pocketbeagle.dts with the respective line names, but I wanted to first integrate feedback regarding P8/P9 on the bone. thanks, drew