From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sivaprakash Murugesan <sivaprak@codeaurora.org>
Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 8/8] arm64: dts: ipq6018: Add a53 pll and apcs clock
Date: Mon, 18 May 2020 11:03:25 -0700 [thread overview]
Message-ID: <20200518180325.GB2165@builder.lan> (raw)
In-Reply-To: <80039c21-41cf-2ace-939a-ef48fd773aa4@codeaurora.org>
On Tue 12 May 20:55 PDT 2020, Sivaprakash Murugesan wrote:
> Hi Bjorn,
>
> On 5/13/2020 1:54 AM, Bjorn Andersson wrote:
> > On Sun 03 May 23:20 PDT 2020, Sivaprakash Murugesan wrote:
> >
> > > add support for apps pll and apcs clock.
> > >
> > > Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 16 +++++++++++++---
> > > 1 file changed, 13 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > > index 1aa8d85..af2ceeb 100644
> > > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > > @@ -294,12 +294,22 @@
> > > };
> > > apcs_glb: mailbox@b111000 {
> > > - compatible = "qcom,ipq8074-apcs-apps-global";
> > > - reg = <0x0b111000 0xc>;
> > > -
> > > + compatible = "qcom,ipq6018-apcs-apps-global";
> > > + reg = <0x0b111000 0x1000>;
> > My documentation states that IPQ8074 indeed has this block at
> > 0x0b111000, but IPQ6018 it's at 0x6b111000. Can you confirm this is
> > correct? Same with the pll below.
> The address 0x6b111000 is how the RPM sees this block. For A53 it is still
> 0xb111000
Okay, thanks for confirming.
Regards,
Bjorn
prev parent reply other threads:[~2020-05-18 18:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 6:20 [PATCH V4 0/8] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 1/8] dt-bindings: mailbox: Add YAML schemas for QCOM APCS global block Sivaprakash Murugesan
2020-05-12 22:46 ` Rob Herring
2020-05-04 6:20 ` [PATCH V4 2/8] dt-bindings: clock: Add schema for QCOM IPQ apss pll Sivaprakash Murugesan
2020-05-12 19:56 ` Bjorn Andersson
2020-05-24 9:49 ` Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 3/8] clk: qcom: Add ipq apss pll driver Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 4/8] clk: qcom: Add DT bindings for ipq6018 apss clock controller Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 5/8] clk: qcom: Add ipq " Sivaprakash Murugesan
2020-05-12 20:12 ` Bjorn Andersson
2020-05-24 9:48 ` Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 6/8] dt-bindings: mailbox: Add dt-bindings for ipq6018 apcs global block Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 7/8] mailbox: qcom: Add ipq6018 apcs compatible Sivaprakash Murugesan
2020-05-12 20:19 ` Bjorn Andersson
2020-05-24 9:45 ` Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 8/8] arm64: dts: ipq6018: Add a53 pll and apcs clock Sivaprakash Murugesan
2020-05-12 20:24 ` Bjorn Andersson
2020-05-13 3:55 ` Sivaprakash Murugesan
2020-05-18 18:03 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518180325.GB2165@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sivaprak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).