From: Eli Riggs <eli@rje.li>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add initial support for Xiaomi Redmi Note 8T
Date: Tue, 19 May 2020 04:20:50 -0700 [thread overview]
Message-ID: <20200519042050.7efd4b0c@casper> (raw)
In-Reply-To: <20200519061114.GC2165@builder.lan>
On Mon, 18 May 2020 23:11:14 -0700
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote:
>
> > Adds initial device tree for Xiaomi Redmi Note 8T, codename
> > xiaomi-willow. It uses the sm6125 SoC. Currently only boots into
> > initrd shell over UART. Requires appended DTB with qcom,board-id =
> > <0x22 0x0> and qcom,msm-id = <0x18a 0x10000> to actually boot.
> >
>
> If I read this correctly you need to supply board-id and msm-id in
> order to be able to get this booting?
>
> Even though we don't like them, I would prefer if you just add them in
> the dts file, in this patch.
Yes, AFAICT the bootloader iterates over the appended DTBs and will
only boot if it finds one with those matching properties.
> > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb diff --git
> > a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts
> > b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts new file mode
> > 100644 index 0000000000000..444b32ccb9d48 --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts
> > @@ -0,0 +1,19 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
>
> Please make this GPL/BSD dual license.
>
> Apart from these few remarks your patches looks good, looking forward
> to see more of this platform!
>
> Regards,
> Bjorn
OK, thanks!
next prev parent reply other threads:[~2020-05-19 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 11:54 [PATCH 1/3] dt-bindings: arm: qcom: Add sm6125 SoC and xiaomi,willow Eli Riggs
2020-05-17 11:54 ` [PATCH 2/3] arm64: dts: qcom: Add initial sm6125 SoC support Eli Riggs
2020-05-19 6:08 ` Bjorn Andersson
2020-05-19 11:18 ` Eli Riggs
2020-05-20 6:14 ` Bjorn Andersson
2020-05-17 11:54 ` [PATCH 3/3] arm64: dts: qcom: Add initial support for Xiaomi Redmi Note 8T Eli Riggs
2020-05-19 6:11 ` Bjorn Andersson
2020-05-19 11:20 ` Eli Riggs [this message]
2020-05-28 20:28 ` [PATCH 1/3] dt-bindings: arm: qcom: Add sm6125 SoC and xiaomi,willow Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519042050.7efd4b0c@casper \
--to=eli@rje.li \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).