From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tali Perry <tali.perry1@gmail.com>
Cc: ofery@google.com, brendanhiggins@google.com,
avifishman70@gmail.com, tmaimon77@gmail.com, kfting@nuvoton.com,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
robh+dt@kernel.org, wsa@the-dreams.de,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton
Date: Fri, 22 May 2020 15:32:48 +0300 [thread overview]
Message-ID: <20200522123248.GC1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200522113312.181413-4-tali.perry1@gmail.com>
On Fri, May 22, 2020 at 02:33:12PM +0300, Tali Perry wrote:
> Add support for slave mode for Nuvoton
> NPCM BMC I2C controller driver.
I guess it will require v14, so, few nits below.
...
> +const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = {
> + NPCM_I2CADDR1, NPCM_I2CADDR2,
> + NPCM_I2CADDR3, NPCM_I2CADDR4,
> + NPCM_I2CADDR5, NPCM_I2CADDR6,
> + NPCM_I2CADDR7, NPCM_I2CADDR8,
> + NPCM_I2CADDR9, NPCM_I2CADDR10,
One TAB is enough.
> + };
No need to indent at all.
...
> + /* Set and enable the address */
> + iowrite8(sa_reg, bus->reg + npcm_i2caddr[(int)addr_type]);
I'm wondering why you need a casting here.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-05-22 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 11:33 [PATCH v13 0/3] i2c: npcm7xx: add NPCM i2c controller driver Tali Perry
2020-05-22 11:33 ` [PATCH v13 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller Tali Perry
2020-05-22 22:42 ` Rob Herring
2020-05-22 22:47 ` Rob Herring
2020-05-24 8:35 ` Tali Perry
2020-05-22 11:33 ` [PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver Tali Perry
2020-05-22 12:27 ` Andy Shevchenko
2020-05-24 12:20 ` kbuild test robot
2020-05-22 11:33 ` [PATCH v13 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton Tali Perry
2020-05-22 12:32 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522123248.GC1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kfting@nuvoton.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofery@google.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wsa@the-dreams.de \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).