From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F71C433E0 for ; Fri, 22 May 2020 17:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2564920723 for ; Fri, 22 May 2020 17:33:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xM7/kxVn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730702AbgEVRdu (ORCPT ); Fri, 22 May 2020 13:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730636AbgEVRdu (ORCPT ); Fri, 22 May 2020 13:33:50 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1C9C061A0E for ; Fri, 22 May 2020 10:33:50 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id n15so5261492pjt.4 for ; Fri, 22 May 2020 10:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2tZSSQp+Q6NkFkvGgoTM41d8a2brRtjrb60yXEtR4oc=; b=xM7/kxVnNd5tkM3aD88kh404nBLGZ0PykMDKj1PajSxvbZKv5gN1DQN4908oXvpFkT D5j4s7pQVcv3lluXjL5hsxnA5VxVZtG0VkOtyF+z/kqlbmj4mJwBQsl5vSglfKkcR8nn hCubMPJ6ImS9MjzxWO29RgINWtO+wzHImrvVO8bqT+EgexwI4z0GvFjyJSQuvA0RU0kK XlRnMSnPgLf+iGmebcMZntq3a8e1GSzPZl1G1vlmX5mofuMANElZbQzYDpVk5myzPSTI AGp8GUBRrS5t+JdFrWN109JV1COJz5flF4tptKa4cikXYJEW3rP9B8NjoLN/dHAbj2yd l8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2tZSSQp+Q6NkFkvGgoTM41d8a2brRtjrb60yXEtR4oc=; b=ZdyVWmkp4bFmlLwLUm9+/PsMEoJEp5bDKKi1sBx3r/mamqKZDU85TmB3rwK/sraNqE 4zthrsu/lJAsDdwxaLZKJyH6PwITAbY/XGpkxEnOAznMyG9qt//x1AWP1qLvZKltF3WO jsMO8qArFTvaXu9EZMexTsBFSkZ+FVjzitbgKYKto4gf7W5IRA9RF1W3YRGu2xkLP6wH jaTmyEPXL0RaswvPpwzqowGE+vhRmV8b8SAWrTTQV1Amo/mc+FIaYqJunyHaHa6ULYnM ft6CQAW0hW4m6HTtsWP7OarEW0bd2rpjpz3ANxKfws7mhY3mrNHbMP6RwJD8kQCTBKiA yR9w== X-Gm-Message-State: AOAM530/8DPGL1CH0rWlZ/aJ3bx65MmSstV81mYaqFWL/dLMUIidVcxD j+aLTP9mwAb6N3gImquF7miV9g== X-Google-Smtp-Source: ABdhPJxs9ytct9W3l8jqHigChSN52KDjrcdPVZee/8dxkQn+Y6KW9FWnWmyEjZpnERt5Wp6T0UgISg== X-Received: by 2002:a17:902:8509:: with SMTP id bj9mr15699226plb.151.1590168829712; Fri, 22 May 2020 10:33:49 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t23sm7426330pji.32.2020.05.22.10.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 10:33:49 -0700 (PDT) Date: Fri, 22 May 2020 10:33:46 -0700 From: Bjorn Andersson To: Suman Anna Cc: Rob Herring , Mathieu Poirier , Clement Leger , Loic Pallardy , Arnaud Pouliquen , Lokesh Vutla , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] remoteproc: add support for a new 64-bit trace version Message-ID: <20200522173346.GJ11847@yoga> References: <20200325204701.16862-1-s-anna@ti.com> <20200325204701.16862-4-s-anna@ti.com> <20200521180417.GJ408178@builder.lan> <997d6f9a-64ba-7a89-e909-9a5a474120b0@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 22 May 09:54 PDT 2020, Suman Anna wrote: > On 5/21/20 2:42 PM, Suman Anna wrote: > > Hi Bjorn, > > > > On 5/21/20 1:04 PM, Bjorn Andersson wrote: > > > On Wed 25 Mar 13:47 PDT 2020, Suman Anna wrote: [..] > > > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h [..] > > > > +struct fw_rsc_trace2 { > > > > > > Sounds more like fw_rsc_trace64 to me - in particular since the version > > > of trace2 is 1... > > > > Yeah, will rename this. > > > > > > > > > +    u32 padding; > > > > +    u64 da; > > > > +    u32 len; > > > > +    u32 reserved; > > > > > > What's the purpose of this reserved field? > > > > Partly to make sure the entire resource is aligned on an 8-byte, and > > partly copied over from fw_rsc_trace entry. I guess 32-bits is already > > large enough of a size for trace entries irrespective of 32-bit or > > 64-bit traces, so I doubt if we want to make the len field also a u64. > > Looking at this again, I can drop both padding and reserved fields, if I > move the len field before da. Any preferences/comments? > Sounds good to me. Thanks, Bjorn