From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98ED5C433E0 for ; Sat, 23 May 2020 23:56:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7259620727 for ; Sat, 23 May 2020 23:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388123AbgEWX4f (ORCPT ); Sat, 23 May 2020 19:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388106AbgEWX4e (ORCPT ); Sat, 23 May 2020 19:56:34 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD0D4C061A0E; Sat, 23 May 2020 16:56:34 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2E5D81287375F; Sat, 23 May 2020 16:56:33 -0700 (PDT) Date: Sat, 23 May 2020 16:56:32 -0700 (PDT) Message-Id: <20200523.165632.2131763470920616688.davem@davemloft.net> To: brgl@bgdev.pl Cc: corbet@lwn.net, matthias.bgg@gmail.com, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, kuba@kernel.org, arnd@arndb.de, fparent@baylibre.com, hkallweit1@gmail.com, edwin.peer@broadcom.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stephane.leprovost@mediatek.com, pedro.tsai@mediatek.com, andrew.perepech@mediatek.com, bgolaszewski@baylibre.com Subject: Re: [PATCH v2 0/5] net: provide a devres variant of register_netdev() From: David Miller In-Reply-To: <20200523132711.30617-1-brgl@bgdev.pl> References: <20200523132711.30617-1-brgl@bgdev.pl> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 May 2020 16:56:33 -0700 (PDT) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Bartosz Golaszewski Date: Sat, 23 May 2020 15:27:06 +0200 > From: Bartosz Golaszewski > > Using devres helpers allows to shrink the probing code, avoid memory leaks in > error paths make sure the order in which resources are freed is the exact > opposite of their allocation. This series proposes to add a devres variant > of register_netdev() that will only work with net_device structures whose > memory is also managed. > > First we add the missing documentation entry for the only other networking > devres helper: devm_alloc_etherdev(). > > Next we move devm_alloc_etherdev() into a separate source file. > > We then use a proxy structure in devm_alloc_etherdev() to improve readability. > > Last: we implement devm_register_netdev() and use it in mtk-eth-mac driver. > > v1 -> v2: > - rebase on top of net-next after driver rename, no functional changes Series applied, thank you.