* [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property [not found] <20200509090456.3496481-1-jacopo@jmondi.org> @ 2020-05-09 9:04 ` Jacopo Mondi 2020-05-25 11:13 ` Pavel Machek 2020-05-09 9:04 ` [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description Jacopo Mondi 2020-05-09 9:04 ` [PATCH v11 13/13] dt-bindings: Add media properties Jacopo Mondi 2 siblings, 1 reply; 10+ messages in thread From: Jacopo Mondi @ 2020-05-09 9:04 UTC (permalink / raw) To: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, Rob Herring Cc: Jacopo Mondi, tfiga, pavel, devicetree, Tomasz Figa Add the 'orientation' device property, used to specify the device mounting position. The property is particularly meaningful for mobile devices with a well defined usage orientation. Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: Tomasz Figa <tfiga@chromium.org> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- .../devicetree/bindings/media/video-interfaces.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index f884ada0bffc8..b1ff492c7da7a 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -89,6 +89,17 @@ Optional properties but a number of degrees counter clockwise. Typical values are 0 and 180 (upside down). +- orientation: The orientation of a device (typically an image sensor or a flash + LED) describing its mounting position relative to the usage orientation of the + system where the device is installed on. + Possible values are: + 0 - Front. The device is mounted on the front facing side of the system. + For mobile devices such as smartphones, tablets and laptops the front side is + the user facing side. + 1 - Back. The device is mounted on the back side of the system, which is + defined as the opposite side of the front facing one. + 2 - External. The device is not attached directly to the system but is + attached in a way that allows it to move freely. Optional endpoint properties ---------------------------- -- 2.26.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property 2020-05-09 9:04 ` [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property Jacopo Mondi @ 2020-05-25 11:13 ` Pavel Machek 0 siblings, 0 replies; 10+ messages in thread From: Pavel Machek @ 2020-05-25 11:13 UTC (permalink / raw) To: Jacopo Mondi Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, Rob Herring, tfiga, devicetree, Tomasz Figa [-- Attachment #1: Type: text/plain, Size: 894 bytes --] Hi! > +- orientation: The orientation of a device (typically an image sensor or a flash > + LED) describing its mounting position relative to the usage orientation of the > + system where the device is installed on. > + Possible values are: > + 0 - Front. The device is mounted on the front facing side of the system. > + For mobile devices such as smartphones, tablets and laptops the front side is > + the user facing side. > + 1 - Back. The device is mounted on the back side of the system, which is > + defined as the opposite side of the front facing one. Well.. except we have devices where camera is both front and back according to this definiton. https://www.gsmarena.com/samsung_galaxy_fold-9523.php Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description [not found] <20200509090456.3496481-1-jacopo@jmondi.org> 2020-05-09 9:04 ` [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property Jacopo Mondi @ 2020-05-09 9:04 ` Jacopo Mondi 2020-05-25 11:16 ` Pavel Machek 2020-05-09 9:04 ` [PATCH v11 13/13] dt-bindings: Add media properties Jacopo Mondi 2 siblings, 1 reply; 10+ messages in thread From: Jacopo Mondi @ 2020-05-09 9:04 UTC (permalink / raw) To: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, Rob Herring Cc: Jacopo Mondi, tfiga, pavel, devicetree Replace the 'rotation' property description by providing a definition relative to the camera sensor pixel array coordinate system and the captured scene. Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- .../bindings/media/video-interfaces.txt | 359 +++++++++++++++++- 1 file changed, 356 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index b1ff492c7da7a..3920f25a91235 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -85,9 +85,362 @@ Optional properties - lens-focus: A phandle to the node of the focus lens controller. -- rotation: The device, typically an image sensor, is not mounted upright, - but a number of degrees counter clockwise. Typical values are 0 and 180 - (upside down). +- rotation: The camera rotation is expressed as the angular difference in + degrees between two reference systems, one relative to the camera module, and + one defined on the external world scene to be captured when projected on the + image sensor pixel array. + + A camera sensor has a 2-dimensional reference system 'Rc' defined by + its pixel array read-out order. The origin is set to the first pixel + being read out, the X-axis points along the column read-out direction + towards the last columns, and the Y-axis along the row read-out + direction towards the last row. + + A typical example for a sensor with a 2592x1944 pixel array matrix + observed from the front is: + + 2591 X-axis 0 + <------------------------+ 0 + .......... ... ..........! + .......... ... ..........! Y-axis + ... ! + .......... ... ..........! + .......... ... ..........! 1943 + V + + The external world scene reference system 'Rs' is a 2-dimensional + reference system on the focal plane of the camera module. The origin is + placed on the top-left corner of the visible scene, the X-axis points + towards the right, and the Y-axis points towards the bottom of the + scene. The top, bottom, left and right directions are intentionally not + defined and depend on the environment in which the camera is used. + + A typical example of a (very common) picture of a shark swimming from + left to right, as seen from the camera, is: + + 0 X-axis + 0 +-------------------------------------> + ! + ! + ! + ! |\____)\___ + ! ) _____ __`< + ! |/ )/ + ! + ! + ! + V + Y-axis + + with the reference system 'Rs' placed on the camera focal plane: + + ¸.·˙! + ¸.·˙ ! + _ ¸.·˙ ! + +-/ \-+¸.·˙ ! + | (o) | ! Camera focal plane + +-----+˙·.¸ ! + ˙·.¸ ! + ˙·.¸ ! + ˙·.¸! + + When projected on the sensor's pixel array, the image and the associated + reference system 'Rs' are typically (but not always) inverted, due to + the camera module's lens optical inversion effect. + + Assuming the above represented scene of the swimming shark, the lens + inversion projects the scene and its reference system onto the sensor + pixel array, seen from the front of the camera sensor, as follows: + + Y-axis + ^ + ! + ! + ! + ! |\_____)\__ + ! ) ____ ___.< + ! |/ )/ + ! + ! + ! + 0 +-------------------------------------> + 0 X-axis + + Note the shark being upside-down. + + The resulting projected reference system is named 'Rp'. + + The camera rotation property is then defined as the angular difference + in the counter-clockwise direction between the camera reference system + 'Rc' and the projected scene reference system 'Rp'. It is expressed in + degrees as a number in the range [0, 360[. + + Examples + + 0 degrees camera rotation: + + + Y-Rp + ^ + Y-Rc ! + ^ ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! 0 +-------------------------------------> + ! 0 X-Rp + 0 +-------------------------------------> + 0 X-Rc + + + X-Rc 0 + <------------------------------------+ 0 + X-Rp 0 ! + <------------------------------------+ 0 ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! V + ! Y-Rc + V + Y-Rp + + 90 degrees camera rotation: + + 0 Y-Rc + 0 +--------------------> + ! Y-Rp + ! ^ + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! 0 +-------------------------------------> + ! 0 X-Rp + ! + ! + ! + ! + V + X-Rc + + 180 degrees camera rotation: + + 0 + <------------------------------------+ 0 + X-Rc ! + Y-Rp ! + ^ ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! V + ! Y-Rc + 0 +-------------------------------------> + 0 X-Rp + + 270 degrees camera rotation: + + 0 Y-Rc + 0 +--------------------> + ! 0 + ! <-----------------------------------+ 0 + ! X-Rp ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! ! + ! V + ! Y-Rp + ! + ! + ! + ! + V + X-Rc + + + Example one - Webcam + + A camera module installed on the user facing part of a laptop screen + casing used for video calls. The captured images are meant to be + displayed in landscape mode (width > height) on the laptop screen. + + The camera is typically mounted upside-down to compensate the lens + optical inversion effect: + + Y-Rp + Y-Rc ^ + ^ ! + ! ! + ! ! |\_____)\__ + ! ! ) ____ ___.< + ! ! |/ )/ + ! ! + ! ! + ! ! + ! 0 +-------------------------------------> + ! 0 X-Rp + 0 +-------------------------------------> + 0 X-Rc + + The two reference systems are aligned, the resulting camera rotation is + 0 degrees, no rotation correction needs to be applied to the resulting + image once captured to memory buffers to correctly display it to users: + + +--------------------------------------+ + ! ! + ! ! + ! ! + ! |\____)\___ ! + ! ) _____ __`< ! + ! |/ )/ ! + ! ! + ! ! + ! ! + +--------------------------------------+ + + If the camera sensor is not mounted upside-down to compensate for the + lens optical inversion, the two reference systems will not be aligned, + with 'Rp' being rotated 180 degrees relatively to 'Rc': + + + X-Rc 0 + <------------------------------------+ 0 + ! + Y-Rp ! + ^ ! + ! ! + ! |\_____)\__ ! + ! ) ____ ___.< ! + ! |/ )/ ! + ! ! + ! ! + ! V + ! Y-Rc + 0 +-------------------------------------> + 0 X-Rp + + The image once captured to memory will then be rotated by 180 degrees: + + +--------------------------------------+ + ! ! + ! ! + ! ! + ! __/(_____/| ! + ! >.___ ____ ( ! + ! \( \| ! + ! ! + ! ! + ! ! + +--------------------------------------+ + + A software rotation correction of 180 degrees should be applied to + correctly display the image: + + +--------------------------------------+ + ! ! + ! ! + ! ! + ! |\____)\___ ! + ! ) _____ __`< ! + ! |/ )/ ! + ! ! + ! ! + ! ! + +--------------------------------------+ + + Example two - Phone camera + + A camera installed on the back side of a mobile device facing away from + the user. The captured images are meant to be displayed in portrait mode + (height > width) to match the device screen orientation and the device + usage orientation used when taking the picture. + + The camera sensor is typically mounted with its pixel array longer side + aligned to the device longer side, upside-down mounted to compensate for + the lens optical inversion effect: + + 0 Y-Rc + 0 +--------------------> + ! Y-Rp + ! ^ + ! ! + ! ! + ! ! + ! ! |\_____)\__ + ! ! ) ____ ___.< + ! ! |/ )/ + ! ! + ! ! + ! ! + ! 0 +-------------------------------------> + ! 0 X-Rp + ! + ! + ! + ! + V + X-Rc + + The two reference systems are not aligned and the 'Rp' reference + system is rotated by 90 degrees in the counter-clockwise direction + relatively to the 'Rc' reference system. + + The image once captured to memory will be rotated: + + +-------------------------------------+ + | _ _ | + | \ / | + | | | | + | | | | + | | > | + | < | | + | | | | + | . | + | V | + +-------------------------------------+ + + A correction of 90 degrees in counter-clockwise direction has to be + applied to correctly display the image in portrait mode on the device + screen: + + +--------------------+ + | | + | | + | | + | | + | | + | | + | |\____)\___ | + | ) _____ __`< | + | |/ )/ | + | | + | | + | | + | | + | | + +--------------------+ - orientation: The orientation of a device (typically an image sensor or a flash LED) describing its mounting position relative to the usage orientation of the -- 2.26.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description 2020-05-09 9:04 ` [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description Jacopo Mondi @ 2020-05-25 11:16 ` Pavel Machek 2020-05-25 12:46 ` Jacopo Mondi 0 siblings, 1 reply; 10+ messages in thread From: Pavel Machek @ 2020-05-25 11:16 UTC (permalink / raw) To: Jacopo Mondi Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, Rob Herring, tfiga, devicetree [-- Attachment #1: Type: text/plain, Size: 1896 bytes --] On Sat 2020-05-09 11:04:45, Jacopo Mondi wrote: > Replace the 'rotation' property description by providing a definition > relative to the camera sensor pixel array coordinate system and the > captured scene. > > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > .../bindings/media/video-interfaces.txt | 359 +++++++++++++++++- > 1 file changed, 356 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > index b1ff492c7da7a..3920f25a91235 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -85,9 +85,362 @@ Optional properties > > - lens-focus: A phandle to the node of the focus lens controller. > > -- rotation: The device, typically an image sensor, is not mounted upright, > - but a number of degrees counter clockwise. Typical values are 0 and 180 > - (upside down). > +- rotation: The camera rotation is expressed as the angular difference in > + degrees between two reference systems, one relative to the camera module, and > + one defined on the external world scene to be captured when projected on the > + image sensor pixel array. So.. how is this supposed to work. There's a phone, with its main camera. It is designed to be used in both portrait and landscape modes, internal accelerometr can tell between the two. Plus you have phone with a keyboard. Common usage is portrait with keyboard closed, and landscape with keyboard open... And yes, there's linux with v4l2 working on Nokia N900. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description 2020-05-25 11:16 ` Pavel Machek @ 2020-05-25 12:46 ` Jacopo Mondi 0 siblings, 0 replies; 10+ messages in thread From: Jacopo Mondi @ 2020-05-25 12:46 UTC (permalink / raw) To: Pavel Machek Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, Rob Herring, tfiga, devicetree [-- Attachment #1: Type: text/plain, Size: 3193 bytes --] Pavel, On Mon, May 25, 2020 at 01:16:21PM +0200, Pavel Machek wrote: > On Sat 2020-05-09 11:04:45, Jacopo Mondi wrote: > > Replace the 'rotation' property description by providing a definition > > relative to the camera sensor pixel array coordinate system and the > > captured scene. > > > > Acked-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > .../bindings/media/video-interfaces.txt | 359 +++++++++++++++++- > > 1 file changed, 356 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > > index b1ff492c7da7a..3920f25a91235 100644 > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -85,9 +85,362 @@ Optional properties > > > > - lens-focus: A phandle to the node of the focus lens controller. > > > > -- rotation: The device, typically an image sensor, is not mounted upright, > > - but a number of degrees counter clockwise. Typical values are 0 and 180 > > - (upside down). > > +- rotation: The camera rotation is expressed as the angular difference in > > + degrees between two reference systems, one relative to the camera module, and > > + one defined on the external world scene to be captured when projected on the > > + image sensor pixel array. > > So.. how is this supposed to work. There's a phone, with its main > camera. It is designed to be used in both portrait and landscape > modes, internal accelerometr can tell between the two. > > Plus you have phone with a keyboard. Common usage is portrait with > keyboard closed, and landscape with keyboard open... > While I agree for 'orientation' we're far from perfection (and that's why I've been asked s/location/orientation/ to reserve 'location' for the future), 'rotation' is only defined by the camera sensor mounting rotation and the external scene. The way you move your phone should not impact the pixel read-out sequence. All phones can be used in portarait or landscape mode, I don't see why having a mechanical keyboard is different. You can type in landscape mode on a touchscreen keyboard, if you like to. The property gives you the rotation correction (actually, the control gives the correction) for display in the 'intended usage orientation'. If your concern is displaying the image, as you sense the accellerometers to rotate the UI, the application that display the image will be rotated too, adding to the corrected image (capture image + rotation here specified) the required UI rotation. On the 'intended usage orientation', as there is one for the UI, there is one for all other components in the phone, so if your system establishes that 'portrait' is the (rotation = 0) point for the UI, this applies to the rest of the system. > And yes, there's linux with v4l2 working on Nokia N900. > How is this and orientation handled there ? > Best regards, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v11 13/13] dt-bindings: Add media properties [not found] <20200509090456.3496481-1-jacopo@jmondi.org> 2020-05-09 9:04 ` [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property Jacopo Mondi 2020-05-09 9:04 ` [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description Jacopo Mondi @ 2020-05-09 9:04 ` Jacopo Mondi 2020-05-11 7:27 ` Hans Verkuil 2020-05-18 18:21 ` Rob Herring 2 siblings, 2 replies; 10+ messages in thread From: Jacopo Mondi @ 2020-05-09 9:04 UTC (permalink / raw) To: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, Rob Herring Cc: Jacopo Mondi, tfiga, pavel, devicetree Add a DT header file to contain definitions for standard media properties. The file is named after: Documentation/devicetree/bindings/media/video-interfaces.txt which contains the standard media properties definitions. Initially add three macros to define the supported 'orientation' property values. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- I currently don't have users in mainline for this, I understand this implies this is probably not going to be accepted. At the same time we don't have a common place for media-related definitions, which support properties defined in video-interfaces.txt I leave it here at the end of the series for discussions, but I'm fine dropping it from the series. Thanks j --- include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 include/dt-bindings/media/video-interfaces.h diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h new file mode 100644 index 0000000000000..404c697d6bd6e --- /dev/null +++ b/include/dt-bindings/media/video-interfaces.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * include/dt-bindings/media/video-interfaces.h + * + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> + */ + +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ + +#define FRONT_CAMERA <0> +#define BACK_CAMERA <1> +#define EXTERNAL_CAMERA <2> + +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ -- 2.26.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v11 13/13] dt-bindings: Add media properties 2020-05-09 9:04 ` [PATCH v11 13/13] dt-bindings: Add media properties Jacopo Mondi @ 2020-05-11 7:27 ` Hans Verkuil 2020-05-20 7:52 ` Jacopo Mondi 2020-05-18 18:21 ` Rob Herring 1 sibling, 1 reply; 10+ messages in thread From: Hans Verkuil @ 2020-05-11 7:27 UTC (permalink / raw) To: Jacopo Mondi, open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Sakari Ailus, Laurent Pinchart, Rob Herring Cc: tfiga, pavel, devicetree On 09/05/2020 11:04, Jacopo Mondi wrote: > Add a DT header file to contain definitions for standard media properties. > > The file is named after: > Documentation/devicetree/bindings/media/video-interfaces.txt > which contains the standard media properties definitions. > > Initially add three macros to define the supported 'orientation' > property values. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > > I currently don't have users in mainline for this, I understand this implies > this is probably not going to be accepted. At the same time we don't have a > common place for media-related definitions, which support properties defined in > video-interfaces.txt > > I leave it here at the end of the series for discussions, but I'm fine dropping > it from the series. > > Thanks > j > > --- > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 include/dt-bindings/media/video-interfaces.h > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h > new file mode 100644 > index 0000000000000..404c697d6bd6e > --- /dev/null > +++ b/include/dt-bindings/media/video-interfaces.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * include/dt-bindings/media/video-interfaces.h > + * > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> > + */ > + > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > + > +#define FRONT_CAMERA <0> > +#define BACK_CAMERA <1> > +#define EXTERNAL_CAMERA <2> Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ? I'm skipping this patch for the PR. Regards, Hans > + > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ > -- > 2.26.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v11 13/13] dt-bindings: Add media properties 2020-05-11 7:27 ` Hans Verkuil @ 2020-05-20 7:52 ` Jacopo Mondi 2020-06-24 13:46 ` Hans Verkuil 0 siblings, 1 reply; 10+ messages in thread From: Jacopo Mondi @ 2020-05-20 7:52 UTC (permalink / raw) To: Hans Verkuil Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Sakari Ailus, Laurent Pinchart, Rob Herring, tfiga, pavel, devicetree Hi Hans, On Mon, May 11, 2020 at 09:27:57AM +0200, Hans Verkuil wrote: > On 09/05/2020 11:04, Jacopo Mondi wrote: > > Add a DT header file to contain definitions for standard media properties. > > > > The file is named after: > > Documentation/devicetree/bindings/media/video-interfaces.txt > > which contains the standard media properties definitions. > > > > Initially add three macros to define the supported 'orientation' > > property values. > > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > > > I currently don't have users in mainline for this, I understand this implies > > this is probably not going to be accepted. At the same time we don't have a > > common place for media-related definitions, which support properties defined in > > video-interfaces.txt > > > > I leave it here at the end of the series for discussions, but I'm fine dropping > > it from the series. > > > > Thanks > > j > > > > --- > > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > create mode 100644 include/dt-bindings/media/video-interfaces.h > > > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h > > new file mode 100644 > > index 0000000000000..404c697d6bd6e > > --- /dev/null > > +++ b/include/dt-bindings/media/video-interfaces.h > > @@ -0,0 +1,15 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * include/dt-bindings/media/video-interfaces.h > > + * > > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> > > + */ > > + > > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > > + > > +#define FRONT_CAMERA <0> > > +#define BACK_CAMERA <1> > > +#define EXTERNAL_CAMERA <2> > > Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ? I used that notation to be able to write orientation = FRONT_CAMERA in place of orientation = <FRONT_CAMERA> Do you think it's wrong ? Thanks j > > I'm skipping this patch for the PR. > > Regards, > > Hans > > > + > > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ > > -- > > 2.26.1 > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v11 13/13] dt-bindings: Add media properties 2020-05-20 7:52 ` Jacopo Mondi @ 2020-06-24 13:46 ` Hans Verkuil 0 siblings, 0 replies; 10+ messages in thread From: Hans Verkuil @ 2020-06-24 13:46 UTC (permalink / raw) To: Jacopo Mondi Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Sakari Ailus, Laurent Pinchart, Rob Herring, tfiga, pavel, devicetree On 20/05/2020 09:52, Jacopo Mondi wrote: > Hi Hans, > > On Mon, May 11, 2020 at 09:27:57AM +0200, Hans Verkuil wrote: >> On 09/05/2020 11:04, Jacopo Mondi wrote: >>> Add a DT header file to contain definitions for standard media properties. >>> >>> The file is named after: >>> Documentation/devicetree/bindings/media/video-interfaces.txt >>> which contains the standard media properties definitions. >>> >>> Initially add three macros to define the supported 'orientation' >>> property values. >>> >>> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> >>> --- >>> >>> I currently don't have users in mainline for this, I understand this implies >>> this is probably not going to be accepted. At the same time we don't have a >>> common place for media-related definitions, which support properties defined in >>> video-interfaces.txt >>> >>> I leave it here at the end of the series for discussions, but I'm fine dropping >>> it from the series. >>> >>> Thanks >>> j >>> >>> --- >>> include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> create mode 100644 include/dt-bindings/media/video-interfaces.h >>> >>> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h >>> new file mode 100644 >>> index 0000000000000..404c697d6bd6e >>> --- /dev/null >>> +++ b/include/dt-bindings/media/video-interfaces.h >>> @@ -0,0 +1,15 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +/* >>> + * include/dt-bindings/media/video-interfaces.h >>> + * >>> + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> >>> + */ >>> + >>> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ >>> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ >>> + >>> +#define FRONT_CAMERA <0> >>> +#define BACK_CAMERA <1> >>> +#define EXTERNAL_CAMERA <2> >> >> Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ? > > I used that notation to be able to write > orientation = FRONT_CAMERA > in place of > orientation = <FRONT_CAMERA> > > Do you think it's wrong ? Yes, I think that's wrong :-) From what I can see in existing device tree files you do not hide the '<>'. Regards, Hans > > Thanks > j > >> >> I'm skipping this patch for the PR. >> >> Regards, >> >> Hans >> >>> + >>> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ >>> -- >>> 2.26.1 >>> >> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v11 13/13] dt-bindings: Add media properties 2020-05-09 9:04 ` [PATCH v11 13/13] dt-bindings: Add media properties Jacopo Mondi 2020-05-11 7:27 ` Hans Verkuil @ 2020-05-18 18:21 ` Rob Herring 1 sibling, 0 replies; 10+ messages in thread From: Rob Herring @ 2020-05-18 18:21 UTC (permalink / raw) To: Jacopo Mondi Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB), libcamera-devel, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus, Laurent Pinchart, tfiga, pavel, devicetree On Sat, May 09, 2020 at 11:04:56AM +0200, Jacopo Mondi wrote: > Add a DT header file to contain definitions for standard media properties. > > The file is named after: > Documentation/devicetree/bindings/media/video-interfaces.txt > which contains the standard media properties definitions. > > Initially add three macros to define the supported 'orientation' > property values. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > > I currently don't have users in mainline for this, I understand this implies > this is probably not going to be accepted. At the same time we don't have a > common place for media-related definitions, which support properties defined in > video-interfaces.txt Fine for me with no users if values already defined in binding. > > I leave it here at the end of the series for discussions, but I'm fine dropping > it from the series. > > Thanks > j > > --- > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 include/dt-bindings/media/video-interfaces.h > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h > new file mode 100644 > index 0000000000000..404c697d6bd6e > --- /dev/null > +++ b/include/dt-bindings/media/video-interfaces.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ Dual license please. > +/* > + * include/dt-bindings/media/video-interfaces.h > + * > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> > + */ > + > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > + > +#define FRONT_CAMERA <0> > +#define BACK_CAMERA <1> > +#define EXTERNAL_CAMERA <2> > + > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ > -- > 2.26.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-06-24 13:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200509090456.3496481-1-jacopo@jmondi.org>
2020-05-09 9:04 ` [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property Jacopo Mondi
2020-05-25 11:13 ` Pavel Machek
2020-05-09 9:04 ` [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description Jacopo Mondi
2020-05-25 11:16 ` Pavel Machek
2020-05-25 12:46 ` Jacopo Mondi
2020-05-09 9:04 ` [PATCH v11 13/13] dt-bindings: Add media properties Jacopo Mondi
2020-05-11 7:27 ` Hans Verkuil
2020-05-20 7:52 ` Jacopo Mondi
2020-06-24 13:46 ` Hans Verkuil
2020-05-18 18:21 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).