From: Pavel Machek <pavel@ucw.cz>
To: Rob Herring <robh@kernel.org>
Cc: Dan Murphy <dmurphy@ti.com>,
jacek.anaszewski@gmail.com, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention
Date: Wed, 27 May 2020 15:39:48 +0200 [thread overview]
Message-ID: <20200527133948.GA5011@amd> (raw)
In-Reply-To: <20200527014902.GA859634@bogus>
[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]
Hi!
Thanks for reviews!
> > +additionalProperties: false
> > +...
> > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
>
> This isn't a binding file. Belongs in another patch.
These constants are directly related to the binding. It makes sense to
go in one patch...
Best regards,
Pavel
> > index f1f718dbe0f8..846248a0693d 100644
> > --- a/drivers/leds/led-core.c
> > +++ b/drivers/leds/led-core.c
> > @@ -34,6 +34,7 @@ const char * const led_colors[LED_COLOR_ID_MAX] = {
> > [LED_COLOR_ID_VIOLET] = "violet",
> > [LED_COLOR_ID_YELLOW] = "yellow",
> > [LED_COLOR_ID_IR] = "ir",
> > + [LED_COLOR_ID_MULTI] = "multicolor",
> > };
> > EXPORT_SYMBOL_GPL(led_colors);
> >
> > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> > index 0ce7dfc00dcb..a463ce6a8794 100644
> > --- a/include/dt-bindings/leds/common.h
> > +++ b/include/dt-bindings/leds/common.h
> > @@ -30,7 +30,8 @@
> > #define LED_COLOR_ID_VIOLET 5
> > #define LED_COLOR_ID_YELLOW 6
> > #define LED_COLOR_ID_IR 7
> > -#define LED_COLOR_ID_MAX 8
> > +#define LED_COLOR_ID_MULTI 8
> > +#define LED_COLOR_ID_MAX 9
> >
> > /* Standard LED functions */
> > /* Keyboard LEDs, usually it would be input4::capslock etc. */
> > --
> > 2.25.1
> >
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-05-27 13:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 16:46 [PATCH v25 00/16] Multicolor Framework v25 Dan Murphy
2020-05-26 16:46 ` [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-05-27 1:49 ` Rob Herring
2020-05-27 13:39 ` Pavel Machek [this message]
2020-05-27 14:35 ` Rob Herring
2020-06-02 20:04 ` Pavel Machek
2020-06-02 21:44 ` Rob Herring
2020-06-04 12:51 ` Pavel Machek
2020-06-04 22:35 ` Rob Herring
2020-06-05 12:11 ` Pavel Machek
2020-05-26 16:46 ` [PATCH v25 02/16] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-05-26 16:46 ` [PATCH v25 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-05-27 1:59 ` Rob Herring
2020-05-27 17:27 ` Dan Murphy
2020-05-27 13:58 ` Pavel Machek
2020-05-27 15:05 ` Dan Murphy
2020-05-31 19:06 ` Pavel Machek
2020-06-01 9:34 ` Jacek Anaszewski
2020-06-04 16:28 ` Dan Murphy
2020-05-26 16:46 ` [PATCH v25 04/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-05-26 16:46 ` [PATCH v25 05/16] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2020-05-27 1:59 ` Rob Herring
2020-05-26 16:46 ` [PATCH v25 06/16] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2020-05-27 2:01 ` Rob Herring
2020-05-27 15:41 ` Dan Murphy
2020-05-26 16:46 ` [PATCH v25 07/16] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-05-26 16:46 ` [PATCH v25 08/16] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-05-26 16:46 ` [PATCH v25 09/16] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-05-26 16:46 ` [PATCH v25 10/16] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-05-26 16:46 ` [PATCH v25 11/16] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-05-26 16:46 ` [PATCH v25 12/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-05-26 16:46 ` [PATCH v25 13/16] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-05-26 16:46 ` [PATCH v25 14/16] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2020-05-26 16:46 ` [PATCH v25 15/16] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2020-05-26 16:46 ` [PATCH v25 16/16] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527133948.GA5011@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).