Devicetree
 help / color / mirror / Atom feed
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Rob Herring <robh+dt@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	<linux-mips@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example
Date: Wed, 27 May 2020 18:33:51 +0300	[thread overview]
Message-ID: <20200527153351.rmzguymz7lm6gvsx@mobilestation> (raw)
In-Reply-To: <20200527153046.6172-3-Sergey.Semin@baikalelectronics.ru>

Rob,
Could you pay attention to this patch? The patchset review procedure is
nearly over, while the DT part is only partly reviewed by you.

Thanks
-Sergey

On Wed, May 27, 2020 at 06:30:37PM +0300, Serge Semin wrote:
> dtc currently doesn't support I2C_OWN_SLAVE_ADDRESS flag set in the
> i2c "reg" property. If it is the compiler will print a warning:
> 
> Warning (i2c_bus_reg): /example-2/i2c@1120000/eeprom@64: I2C bus unit address format error, expected "40000064"
> Warning (i2c_bus_reg): /example-2/i2c@1120000/eeprom@64:reg: I2C address must be less than 10-bits, got "0x40000064"
> 
> In order to silence dtc up let's discard the flag from the DW I2C DT
> binding example for now. Just revert this commit when dtc is fixed.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: linux-mips@vger.kernel.org
> 
> ---
> 
> Changelog v3:
> - This is a new patch created as a result of the Rob request to remove
>   the EEPROM-slave bit setting in the DT binndings example until the dtc
>   is fixed.
> ---
>  Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> index 4bd430b2b41d..101d78e8f19d 100644
> --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> @@ -137,7 +137,7 @@ examples:
>  
>        eeprom@64 {
>          compatible = "linux,slave-24c02";
> -        reg = <0x40000064>;
> +        reg = <0x64>;
>        };
>      };
>    - |
> -- 
> 2.26.2
> 

  reply	other threads:[~2020-05-27 15:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 15:30 [PATCH v5 00/11] i2c: designeware: Add Baikal-T1 System I2C support Serge Semin
2020-05-27 15:30 ` [PATCH v5 01/11] dt-bindings: i2c: Convert DW I2C binding to DT schema Serge Semin
2020-05-27 15:30 ` [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example Serge Semin
2020-05-27 15:33   ` Serge Semin [this message]
2020-05-29 18:13     ` Rob Herring
2020-05-29 18:22       ` Serge Semin
2020-05-29 18:42         ` Andy Shevchenko
2020-05-29 18:45           ` Serge Semin
2020-05-29 18:58             ` Serge Semin
2020-06-08 23:46               ` Rob Herring
2020-05-27 15:30 ` [PATCH v5 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller Serge Semin
2020-05-27 15:35   ` Serge Semin
2020-05-27 15:30 ` [PATCH v5 04/11] i2c: designware: Use `-y` to build multi-object modules Serge Semin
2020-05-27 15:30 ` [PATCH v5 05/11] i2c: designware: slave: Set DW I2C core module dependency Serge Semin
2020-05-27 15:30 ` [PATCH v5 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency Serge Semin
2020-05-27 15:55   ` Andy Shevchenko
2020-05-27 16:05     ` Serge Semin
2020-05-27 16:44   ` Andy Shevchenko
2020-05-27 15:30 ` [PATCH v5 07/11] i2c: designware: Discard Cherry Trail model flag Serge Semin
2020-05-27 15:57   ` Andy Shevchenko
2020-05-27 16:07     ` Serge Semin
2020-05-27 15:30 ` [PATCH v5 08/11] i2c: designware: Convert driver to using regmap API Serge Semin
2020-05-27 16:03   ` Andy Shevchenko
2020-05-27 16:09     ` Serge Semin
2020-05-27 15:30 ` [PATCH v5 09/11] i2c: designware: Retrieve quirk flags as early as possible Serge Semin
2020-05-27 15:30 ` [PATCH v5 10/11] i2c: designware: Move reg-space remapping into a dedicated function Serge Semin
2020-05-27 15:30 ` [PATCH v5 11/11] i2c: designware: Add Baikal-T1 System I2C support Serge Semin
2020-05-27 16:05   ` Andy Shevchenko
2020-05-27 16:10     ` Serge Semin
2020-05-27 16:08 ` [PATCH v5 00/11] i2c: designeware: " Andy Shevchenko
2020-05-27 16:15   ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527153351.rmzguymz7lm6gvsx@mobilestation \
    --to=sergey.semin@baikalelectronics.ru \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox