From: Rob Herring <robh@kernel.org>
To: Qi Zheng <arch0.zheng@gmail.com>
Cc: frowand.list@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of/fdt: Remove redundant kbasename function call
Date: Wed, 27 May 2020 12:27:08 -0600 [thread overview]
Message-ID: <20200527182708.GA2458626@bogus> (raw)
In-Reply-To: <20200512154909.279788-1-arch0.zheng@gmail.com>
On Tue, May 12, 2020 at 11:49:09PM +0800, Qi Zheng wrote:
> For version 1 to 3 of the device tree, this is the node full
> path as a zero terminated string, starting with "/". The
> following equation will not hold, since the node name has
> been processed in the fdt_get_name().
>
> *pathp == '/'
>
> For version 16 and later, this is the node unit name only
> (or an empty string for the root node). So the above
> equation will still not hold.
>
> So the kbasename() is redundant, just remove it.
There's 2 occurrences of this. Can you remove the other one too.
Rob
next prev parent reply other threads:[~2020-05-27 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 15:49 [PATCH] of/fdt: Remove redundant kbasename function call Qi Zheng
2020-05-13 13:44 ` Qi Zheng
2020-05-27 18:27 ` Rob Herring [this message]
2020-05-28 12:37 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527182708.GA2458626@bogus \
--to=robh@kernel.org \
--cc=arch0.zheng@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).