From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE00C433E0 for ; Thu, 28 May 2020 02:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAB79207E8 for ; Thu, 28 May 2020 02:55:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rPRiE/C7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726914AbgE1Cz4 (ORCPT ); Wed, 27 May 2020 22:55:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbgE1Czz (ORCPT ); Wed, 27 May 2020 22:55:55 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB77CC05BD1E for ; Wed, 27 May 2020 19:55:54 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id ci23so2385583pjb.5 for ; Wed, 27 May 2020 19:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5SLDHaQd2uS3eCJTHPJQrrfMcU5/8VS6v9VhVg+MqpA=; b=rPRiE/C71Lex6MY6ue2I07lDdIDuRXIvxlPlNeLU4heE+XYzy5RjdzZw0WJhFLpnop biu0JhMfZbiDD5jn5p32FSqLAySedAXQf5CQFqnheaN+UkwN6DVfwsP9BTRXnQPekJzq NGgczyNcZE6F3p4DRnncZtRu8vfBaOTbgRcGQ1hXKFFs1Nbv993DgFyFhL0mTKGyQwhC c7SMnBPwfA26z05PGH8k47EaQ7C9uQKB5JiJfan1x0XaJEL3WHrDSGjkIQjalWkrwXzf 9oILXLA/q/u1n5d/g9L4TrTU3kvVzGXV0DblI9GYaj7lwicDS4VZdJZg8SONazqKJxPv D6xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5SLDHaQd2uS3eCJTHPJQrrfMcU5/8VS6v9VhVg+MqpA=; b=IDfoULbmud+hEHB9K/pJTY99A4i0xCMWxQYLy9xjGHOemIym/vkU8Tx3NsJfeV4q9w ZPqU3t4pNAr4We1O3nb1GufwquWaXy+WAAQETN+cq+dKGhCHmeRc1QDHvf6+9P7rb54s hFOFb8//Gva9ol7ajjUGLybeG77H0GxZrSyIXl0rYxp8/3HpMIFiPu4sMzLuD+vOHPCG 8xVDoPePGgNYwQfneebOWFtj77V6NDbbrpJx/14+xCxbaR8idyjBb/bOeMW41pWwTwhy wIMQZwAyuzwu07/CnuHPlVaGKm5A98amSgNhWOkWkAeMuS4/jekX/5YBy2O3YueszFj0 vqFg== X-Gm-Message-State: AOAM533OGEVp+uhNoLnqVu0c5O1lzeov+b45DhKtJ3J0A+s6Qgvca5xF RG9VWQUiAyqY8c5MmbM2TfWkBNGw X-Google-Smtp-Source: ABdhPJx0H2BTm726Up0tqV86OZb/PPLRFz+bnmaSIa+QMLf+un/PK6sVUuyddLNdJZDC/QDhhqYaNw== X-Received: by 2002:a17:90b:3745:: with SMTP id ne5mr1486242pjb.68.1590634554199; Wed, 27 May 2020 19:55:54 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id jx10sm3601816pjb.46.2020.05.27.19.55.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 May 2020 19:55:53 -0700 (PDT) Date: Wed, 27 May 2020 19:55:52 -0700 From: Guenter Roeck To: Andre Przywara Cc: Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 04/20] arm64: dts: arm: vexpress: Move fixed devices out of bus node Message-ID: <20200528025552.GA232631@roeck-us.net> References: <20200513103016.130417-1-andre.przywara@arm.com> <20200513103016.130417-5-andre.przywara@arm.com> <20200528024810.GA232303@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528024810.GA232303@roeck-us.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 27, 2020 at 07:48:10PM -0700, Guenter Roeck wrote: > On Wed, May 13, 2020 at 11:30:00AM +0100, Andre Przywara wrote: > > The devicetree compiler complains when DT nodes without a reg property > > live inside a (simple) bus node: > > Warning (simple_bus_reg): Node /bus@8000000/motherboard-bus/refclk32khz > > missing or empty reg/ranges property > > > > Move the fixed clocks, the fixed regulator, the leds and the config bus > > subtree to the root node, since they do not depend on any busses. > > > > Signed-off-by: Andre Przywara > > This patch results in tracebacks when booting the vexpress-a15 machine > with vexpress-v2p-ca15-tc1 devicetree file in qemu. Reverting it as well > as the subsequent patches affecting the same file (to avoid revert > conflicts) fixes the problem. > On top of that, there is this message: [ 19.817986] vexpress-reset mcc:reboot: Unable to restart (-14) [ 20.818315] Reboot failed -- System halted which also disappears after the patches have been reverted. Here is my list of reverts on top of next-20200526: bdc8a817612b (HEAD -> master) Revert "arm64: dts: vexpress: Move fixed devices out of bus node" 9a1f85df9e1a Revert "arm64: dts: fvp/juno: Fix serial node names" 381e0bbe8c00 Revert "arm64: dts: fvp/juno: Fix bus node names" 63723f67bf4b Revert "arm64: dts: vexpress: Fix VExpress LED names" Guenter > Guenter > > --- > [ 12.744248] ------------[ cut here ]------------ > [ 12.744562] WARNING: CPU: 0 PID: 20 at drivers/tty/serial/serial_core.c:471 uart_get_baud_rate+0x100/0x154 > [ 12.744607] Modules linked in: > [ 12.744785] CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 5.7.0-rc7-next-20200526 #1 > [ 12.744818] Hardware name: ARM-Versatile Express > [ 12.745021] Workqueue: events amba_deferred_retry_func > [ 12.745155] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 12.745206] [] (show_stack) from [] (dump_stack+0xc8/0xdc) > [ 12.745239] [] (dump_stack) from [] (__warn+0xdc/0xf4) > [ 12.745270] [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) > [ 12.745302] [] (warn_slowpath_fmt) from [] (uart_get_baud_rate+0x100/0x154) > [ 12.745336] [] (uart_get_baud_rate) from [] (pl011_set_termios+0x48/0x32c) > [ 12.745367] [] (pl011_set_termios) from [] (uart_set_options+0x124/0x164) > [ 12.745404] [] (uart_set_options) from [] (pl011_console_setup+0x214/0x230) > [ 12.745438] [] (pl011_console_setup) from [] (try_enable_new_console+0x98/0x138) > [ 12.745469] [] (try_enable_new_console) from [] (register_console+0xe8/0x304) > [ 12.745499] [] (register_console) from [] (uart_add_one_port+0x4c0/0x504) > [ 12.745529] [] (uart_add_one_port) from [] (pl011_register_port+0x5c/0xac) > [ 12.745568] [] (pl011_register_port) from [] (amba_probe+0x9c/0x110) > [ 12.745602] [] (amba_probe) from [] (really_probe+0x218/0x348) > [ 12.745632] [] (really_probe) from [] (driver_probe_device+0x5c/0xb4) > [ 12.745662] [] (driver_probe_device) from [] (bus_for_each_drv+0x58/0xb8) > [ 12.745692] [] (bus_for_each_drv) from [] (__device_attach+0xd4/0x140) > [ 12.745721] [] (__device_attach) from [] (bus_probe_device+0x88/0x90) > [ 12.745751] [] (bus_probe_device) from [] (device_add+0x3d4/0x6e8) > [ 12.745782] [] (device_add) from [] (amba_device_try_add+0x50/0x2d4) > [ 12.745812] [] (amba_device_try_add) from [] (amba_deferred_retry+0x3c/0x98) > [ 12.745847] [] (amba_deferred_retry) from [] (amba_deferred_retry_func+0x8/0x40) > [ 12.745881] [] (amba_deferred_retry_func) from [] (process_one_work+0x2b8/0x6e8) > [ 12.745912] [] (process_one_work) from [] (worker_thread+0x44/0x540) > [ 12.745942] [] (worker_thread) from [] (kthread+0x16c/0x178) > [ 12.745973] [] (kthread) from [] (ret_from_fork+0x14/0x2c) > [ 12.746041] Exception stack(0xc73abfb0 to 0xc73abff8) > [ 12.746181] bfa0: 00000000 00000000 00000000 00000000 > [ 12.746302] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 12.746397] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 12.746651] ---[ end trace 2a3f61da56bd8a49 ]--- > > --- > # bad: [b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8] Add linux-next specific files for 20200526 > # good: [9cb1fd0efd195590b828b9b865421ad345a4a145] Linux 5.7-rc7 > git bisect start 'next-20200526' 'v5.7-rc7' > # bad: [0c7351ad83670964e48cb9a098ad732c1ecbf804] Merge remote-tracking branch 'crypto/master' > git bisect bad 0c7351ad83670964e48cb9a098ad732c1ecbf804 > # bad: [42e11d9b4682229fa7187d129758b8c382f8cd5d] Merge remote-tracking branch 'jc_docs/docs-next' > git bisect bad 42e11d9b4682229fa7187d129758b8c382f8cd5d > # bad: [ab6f501559e9efa687c711a781243cf6651a82d3] Merge remote-tracking branch 'm68k/for-next' > git bisect bad ab6f501559e9efa687c711a781243cf6651a82d3 > # bad: [44aaa516ca63b3ab2da8ae81e9c6a58656e6acb5] Merge branch 'arm/drivers' into for-next > git bisect bad 44aaa516ca63b3ab2da8ae81e9c6a58656e6acb5 > # good: [1cb00f8c3b36e6ae026fb58d1cd2ccd78b81aa9f] Merge tag 'qcom-arm64-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux into arm/dt > git bisect good 1cb00f8c3b36e6ae026fb58d1cd2ccd78b81aa9f > # bad: [ed0c25932fbfafdfe37e9633dee21770d3c5a306] Merge branch 'arm/defconfig' into for-next > git bisect bad ed0c25932fbfafdfe37e9633dee21770d3c5a306 > # bad: [9eddc06a3bc79402f50176703237ed045ae77b16] Merge branch 'mmp/fixes' into arm/dt > git bisect bad 9eddc06a3bc79402f50176703237ed045ae77b16 > # bad: [87b990ab62722a8a3cb0691107971ab1bd7bddb5] Merge tag 'mvebu-dt64-5.8-1' of git://git.infradead.org/linux-mvebu into arm/dt > git bisect bad 87b990ab62722a8a3cb0691107971ab1bd7bddb5 > # bad: [94cc3f1baabac5e5c4dcc6c2f070353f8315d0ee] arm64: dts: juno: Fix SCPI shared mem node name > git bisect bad 94cc3f1baabac5e5c4dcc6c2f070353f8315d0ee > # bad: [a78aee9e434932a500db36cc6d88daeff3745e9f] arm64: dts: juno: Fix GIC child nodes > git bisect bad a78aee9e434932a500db36cc6d88daeff3745e9f > # bad: [feebdc3f7950d7e44e914e821f6c04e58e292c74] arm64: dts: fvp: Move fixed clocks out of bus node > git bisect bad feebdc3f7950d7e44e914e821f6c04e58e292c74 > # good: [849bfc3dfc13cde6ec04fbcf32af553ded9f7ec3] arm64: dts: fvp: Move fixed devices out of bus node > git bisect good 849bfc3dfc13cde6ec04fbcf32af553ded9f7ec3 > # bad: [d9258898ad49cbb46caffe23af0d4f0b766e67a2] arm64: dts: vexpress: Move fixed devices out of bus node > git bisect bad d9258898ad49cbb46caffe23af0d4f0b766e67a2 > # first bad commit: [d9258898ad49cbb46caffe23af0d4f0b766e67a2] arm64: dts: vexpress: Move fixed devices out of bus node >