* Re: [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset
2020-05-13 18:48 ` [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset Rodrigo Alencar
@ 2020-05-28 15:02 ` Rob Herring
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-05-28 15:02 UTC (permalink / raw)
To: Rodrigo Alencar
Cc: devicetree, andy.shevchenko, linux-fbdev, linux-kernel,
b.zolnierkie, Rodrigo Rolim Mendes de Alencar
On Wed, 13 May 2020 15:48:11 -0300, Rodrigo Alencar wrote:
> From: Rodrigo Rolim Mendes de Alencar <alencar.fmce@imbel.gov.br>
>
> This patch provides support for displays like VGM128064B0W10,
> which requires a column offset of 2, i.e., its segments starts
> in SEG2 and ends in SEG129.
>
> Signed-off-by: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
> ---
> Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 +
> drivers/video/fbdev/ssd1307fb.c | 8 ++++++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset
2020-05-13 18:48 ` [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset Rodrigo Alencar
2020-05-28 15:02 ` Rob Herring
@ 2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-07-10 14:23 UTC (permalink / raw)
To: Rodrigo Alencar
Cc: linux-fbdev, dri-devel, linux-kernel, andy.shevchenko, devicetree,
Rodrigo Rolim Mendes de Alencar
[ added dri-devel ML to Cc: ]
Hi,
Sorry for the delay.
On 5/13/20 8:48 PM, Rodrigo Alencar wrote:
> From: Rodrigo Rolim Mendes de Alencar <alencar.fmce@imbel.gov.br>
>
> This patch provides support for displays like VGM128064B0W10,
> which requires a column offset of 2, i.e., its segments starts
> in SEG2 and ends in SEG129.
>
> Signed-off-by: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Please resend with "From:" & "Signed-off-by:" tags fixed to match so
I can merge the patch.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 +
> drivers/video/fbdev/ssd1307fb.c | 8 ++++++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/ssd1307fb.txt b/Documentation/devicetree/bindings/display/ssd1307fb.txt
> index 27333b9551b3..2dcb6d12d137 100644
> --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt
> +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt
> @@ -19,6 +19,7 @@ Optional properties:
> - vbat-supply: The supply for VBAT
> - solomon,segment-no-remap: Display needs normal (non-inverted) data column
> to segment mapping
> + - solomon,col-offset: Offset of columns (COL/SEG) that the screen is mapped to.
> - solomon,com-seq: Display uses sequential COM pin configuration
> - solomon,com-lrremap: Display uses left-right COM pin remap
> - solomon,com-invdir: Display uses inverted COM pin scan direction
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 8e06ba912d60..102f941104c0 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -74,6 +74,7 @@ struct ssd1307fb_par {
> struct fb_info *info;
> u8 lookup_table[4];
> u32 page_offset;
> + u32 col_offset;
> u32 prechargep1;
> u32 prechargep2;
> struct pwm_device *pwm;
> @@ -458,11 +459,11 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
> if (ret < 0)
> return ret;
>
> - ret = ssd1307fb_write_cmd(par->client, 0x0);
> + ret = ssd1307fb_write_cmd(par->client, par->col_offset);
> if (ret < 0)
> return ret;
>
> - ret = ssd1307fb_write_cmd(par->client, par->width - 1);
> + ret = ssd1307fb_write_cmd(par->client, par->col_offset + par->width - 1);
> if (ret < 0)
> return ret;
>
> @@ -626,6 +627,9 @@ static int ssd1307fb_probe(struct i2c_client *client)
> if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset))
> par->page_offset = 1;
>
> + if (device_property_read_u32(dev, "solomon,col-offset", &par->col_offset))
> + par->col_offset = 0;
> +
> if (device_property_read_u32(dev, "solomon,com-offset", &par->com_offset))
> par->com_offset = 0;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread