From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFC4C433DF for ; Thu, 28 May 2020 14:45:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D537207D3 for ; Thu, 28 May 2020 14:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728522AbgE1Opr (ORCPT ); Thu, 28 May 2020 10:45:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbgE1Opq (ORCPT ); Thu, 28 May 2020 10:45:46 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EACDC05BD1E for ; Thu, 28 May 2020 07:45:46 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 620552A3D6A; Thu, 28 May 2020 15:45:44 +0100 (BST) Date: Thu, 28 May 2020 16:45:41 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , , Rob Herring , Mark Rutland , , Thomas Petazzoni , Paul Cercueil , Chuanhong Guo , Weijie Gao , , Mason Yang , Julien Su Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200528164541.106bbde9@collabora.com> In-Reply-To: <20200528113113.9166-19-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal wrote: > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index ce936ffb9f42..1cc6d71c2b45 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -127,6 +127,10 @@ struct nand_page_io_req { > int mode; > }; > > +extern const struct mtd_ooblayout_ops nand_ooblayout_sp_ops; > +extern const struct mtd_ooblayout_ops nand_ooblayout_lp_ops; > +extern const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops; While we move that to the generic NAND layer, can we hide that behind helpers so we don't have the objects directly exposed? const struct mtd_ooblayout_ops *nand_get_small_page_layout(); const struct mtd_ooblayout_ops *nand_get_large_page_layout(); const struct mtd_ooblayout_ops *nand_get_large_page_hamming_layout();