From: Rob Herring <robh@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: sre@kernel.org, krzk@kernel.org, jonghwa3.lee@samsung.com,
tglx@linutronix.de, kstewart@linuxfoundation.org,
baolin.wang7@gmail.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] dt-bindings: power: supply: Cleanup charger-manager bindings
Date: Thu, 28 May 2020 11:54:06 -0600 [thread overview]
Message-ID: <20200528175406.GA391088@bogus> (raw)
In-Reply-To: <BN6PR04MB0660E57423994D19C84370A3A3BC0@BN6PR04MB0660.namprd04.prod.outlook.com>
On Thu, May 14, 2020 at 04:04:35PM -0700, Jonathan Bakker wrote:
> The bindings for charger-manager were very unclear and didn't
> specify allowable values in many cases. Clean these up to show
> what each value does and make sure all properties are documented
> here rather than using wildcards.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
> .../bindings/power/supply/charger-manager.txt | 30 ++++++++++++-------
> 1 file changed, 20 insertions(+), 10 deletions(-)
I guess you're just documenting what already exists, but I think this is
not really a binding we want to continue using...
Acked-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2020-05-28 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200514230435.11798-1-xc-racer2@live.ca>
2020-05-14 23:04 ` [PATCH 01/10] power: supply: charger-manager: Swap private uevent for power_supply_changed Jonathan Bakker
2020-05-14 23:04 ` [PATCH 02/10] power: supply: charger-manager: Remove cm_notify_event function Jonathan Bakker
2020-05-14 23:04 ` [PATCH 03/10] power: supply: charger-manager: Always use POWER_SUPPLY_PROP_TEMP Jonathan Bakker
2020-05-14 23:04 ` [PATCH 04/10] power: supply: charger-manager: Correct usage of CHARGE_NOW/FULL Jonathan Bakker
2020-05-14 23:04 ` [PATCH 05/10] power: supply: charger-manager: Collect all power_supply_changed() calls Jonathan Bakker
2020-05-14 23:04 ` [PATCH 06/10] power: supply: charger-manager: Make decisions focussed on battery status Jonathan Bakker
2020-05-14 23:04 ` [PATCH 07/10] power: supply: charger-manager: Don't start charging in cable nofitication Jonathan Bakker
2020-05-14 23:04 ` [PATCH 08/10] power: supply: charger-manager: Update extcon functions Jonathan Bakker
2020-05-14 23:04 ` [PATCH 09/10] power: supply: charger-manager: Count cm-chargers property directly Jonathan Bakker
2020-05-14 23:04 ` [PATCH 10/10] dt-bindings: power: supply: Cleanup charger-manager bindings Jonathan Bakker
2020-05-28 17:54 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528175406.GA391088@bogus \
--to=robh@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonghwa3.lee@samsung.com \
--cc=krzk@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).