From: Rob Herring <robh@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: daniel.lezcano@linaro.org, tglx@linutronix.de,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, ping.bai@nxp.com,
aisheng.dong@nxp.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux-imx@nxp.com
Subject: Re: [PATCH V2 1/3] dt-bindings: timer: Convert i.MX GPT to json-schema
Date: Thu, 28 May 2020 14:58:34 -0600 [thread overview]
Message-ID: <20200528205834.GA660327@bogus> (raw)
In-Reply-To: <1589860547-3207-2-git-send-email-Anson.Huang@nxp.com>
On Tue, May 19, 2020 at 11:55:45AM +0800, Anson Huang wrote:
> Convert the i.MX GPT binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - remove unnecessary compatible item descriptions;
> - remove unnecessary maxItems for clocks/clock-names;
> ---
> .../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ------------
> .../devicetree/bindings/timer/fsl,imxgpt.yaml | 80 ++++++++++++++++++++++
> 2 files changed, 80 insertions(+), 45 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> create mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> deleted file mode 100644
> index 5d8fd5b..0000000
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -Freescale i.MX General Purpose Timer (GPT)
> -
> -Required properties:
> -
> -- compatible : should be one of following:
> - for i.MX1:
> - - "fsl,imx1-gpt";
> - for i.MX21:
> - - "fsl,imx21-gpt";
> - for i.MX27:
> - - "fsl,imx27-gpt", "fsl,imx21-gpt";
> - for i.MX31:
> - - "fsl,imx31-gpt";
> - for i.MX25:
> - - "fsl,imx25-gpt", "fsl,imx31-gpt";
> - for i.MX50:
> - - "fsl,imx50-gpt", "fsl,imx31-gpt";
> - for i.MX51:
> - - "fsl,imx51-gpt", "fsl,imx31-gpt";
> - for i.MX53:
> - - "fsl,imx53-gpt", "fsl,imx31-gpt";
> - for i.MX6Q:
> - - "fsl,imx6q-gpt", "fsl,imx31-gpt";
> - for i.MX6DL:
> - - "fsl,imx6dl-gpt";
> - for i.MX6SL:
> - - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt";
> - for i.MX6SX:
> - - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt";
> -- reg : specifies base physical address and size of the registers.
> -- interrupts : should be the gpt interrupt.
> -- clocks : the clocks provided by the SoC to drive the timer, must contain
> - an entry for each entry in clock-names.
> -- clock-names : must include "ipg" entry first, then "per" entry.
> -
> -Example:
> -
> -gpt1: timer@10003000 {
> - compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
> - reg = <0x10003000 0x1000>;
> - interrupts = <26>;
> - clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
> - <&clks IMX27_CLK_PER1_GATE>;
> - clock-names = "ipg", "per";
> -};
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> new file mode 100644
> index 0000000..5479290
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX General Purpose Timer (GPT)
> +
> +maintainers:
> + - Sascha Hauer <s.hauer@pengutronix.de>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: "fsl,imx1-gpt"
> + - const: "fsl,imx21-gpt"
> + - items:
> + - const: "fsl,imx27-gpt"
> + - const: "fsl,imx21-gpt"
> + - const: "fsl,imx31-gpt"
> + - items:
> + - const: "fsl,imx25-gpt"
> + - const: "fsl,imx31-gpt"
> + - items:
> + - const: "fsl,imx50-gpt"
> + - const: "fsl,imx31-gpt"
> + - items:
> + - const: "fsl,imx51-gpt"
> + - const: "fsl,imx31-gpt"
> + - items:
> + - const: "fsl,imx53-gpt"
> + - const: "fsl,imx31-gpt"
> + - items:
> + - const: "fsl,imx6q-gpt"
> + - const: "fsl,imx31-gpt"
> + - const: "fsl,imx6dl-gpt"
> + - items:
> + - const: "fsl,imx6sl-gpt"
> + - const: "fsl,imx6dl-gpt"
> + - items:
> + - const: "fsl,imx6sx-gpt"
> + - const: "fsl,imx6dl-gpt"
Don't need quotes.
Group all the ones with the same fallback to a single 'items' list
using enum for the first entry.
Rob
next prev parent reply other threads:[~2020-05-28 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 3:55 [PATCH V2 0/3] Covert i.MX GPT/TPM/SYSCTR timer binding to json-schema Anson Huang
2020-05-19 3:55 ` [PATCH V2 1/3] dt-bindings: timer: Convert i.MX GPT " Anson Huang
2020-05-19 5:08 ` Aisheng Dong
2020-05-28 20:58 ` Rob Herring [this message]
2020-05-19 3:55 ` [PATCH V2 2/3] dt-bindings: timer: Convert i.MX TPM " Anson Huang
2020-05-28 20:59 ` Rob Herring
2020-05-19 3:55 ` [PATCH V2 3/3] dt-bindings: timer: Convert i.MX SYSCTR " Anson Huang
2020-05-28 21:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528205834.GA660327@bogus \
--to=robh@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).