From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50934C433E4 for ; Fri, 29 May 2020 17:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32F4A206A4 for ; Fri, 29 May 2020 17:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590774546; bh=P0UfxUn59TBgODAkkR1p5Fu2q/qr2hoNA6PpLGpZCd0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rvhC2pXy7ga9YPNjIsck7UqFhHPy+ZD37uDiCtfH5vJrg2hXbc8osFqMsuD0zpuRg x1FnwQqnsG+DvDpd8f+Qsr5vrAUcrTSU/1+PH4FWQhCRcgoXhThinP7aVVQzdTwykm KYKRtQ+UgEn31A78o5gz12GbbP4BPZhAYwmRGQmY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgE2RtC (ORCPT ); Fri, 29 May 2020 13:49:02 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:39959 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgE2RtC (ORCPT ); Fri, 29 May 2020 13:49:02 -0400 Received: by mail-io1-f65.google.com with SMTP id q8so233545iow.7; Fri, 29 May 2020 10:49:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BLn5568WhOcT6+u2ym9/jBhSyqxnYH4n/L9rj2t60QE=; b=d54Y283E1oQ+RjivvIpjdY9uNABr5wdispcYRSKOHcKa9/rUU34cTLD3XdajfnzzhS FDFS/frsja7WGqBBmoDx9cvAp/dh+A9b504SX8x3NwTQJcGDnOoI5tU3AA5Nb6HvUvQy QlJ0a578sr6ytgdqOzjJ2VyU7DUAwz5FNQOgQPuyy55+kdT5gYl64R8oB7BI+SIbsJDh Fn4HG7ms2wSFzurdV6NebxCkPVzOI3HUPUZkHnya7L93gsW6w57D7iJeIBYnoLfxaYVD 4+yScvvXkk5+NO6LukXr9A1qjTJYWg7XJUryX0UOxCdjzquhBvW46DLWD1Z+pjd/liYF NyiA== X-Gm-Message-State: AOAM53259brQHbu8tkTd9wo8PEiTLcvulzL/TY3G9AXUwJ3Ct+a1SEk9 JP1MuK57hR+lwPpywtMsxg== X-Google-Smtp-Source: ABdhPJy7YUF3lpxrD7YMnpI0UvB3HdDPYFVO6rRfufgNQwXAXOB9FeWO8U/8UblJM9K1CPtEmWfdwQ== X-Received: by 2002:a02:1443:: with SMTP id 64mr2603674jag.43.1590774540749; Fri, 29 May 2020 10:49:00 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id t22sm4001987iom.49.2020.05.29.10.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 10:49:00 -0700 (PDT) Received: (nullmailer pid 2643995 invoked by uid 1000); Fri, 29 May 2020 17:48:58 -0000 Date: Fri, 29 May 2020 11:48:58 -0600 From: Rob Herring To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Christoph Hellwig , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, Alan Stern , Andy Shevchenko , Corey Minyard , Dan Williams , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" , Greg Kroah-Hartman , Heikki Krogerus , "open list:DMA MAPPING HELPERS" , Julien Grall , "moderated list:ARM PORT" , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:USB SUBSYSTEM" , Mark Brown , Oliver Neukum , "Rafael J. Wysocki" , Robin Murphy , Saravana Kannan , Stefano Stabellini , Suzuki K Poulose , Ulf Hansson , Wolfram Sang Subject: Re: [PATCH v2 00/14] PCI: brcmstb: enable PCIe for STB chips Message-ID: <20200529174858.GA2640397@bogus> References: <20200526191303.1492-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526191303.1492-1-james.quinlan@broadcom.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 26, 2020 at 03:12:39PM -0400, Jim Quinlan wrote: > v2: > Commit: "device core: Add ability to handle multiple dma offsets" > o Added helper func attach_dma_pfn_offset_map() in address.c (Chistoph) > o Helpers funcs added to __phys_to_dma() & __dma_to_phys() (Christoph) > o Added warning when multiple offsets are needed and !DMA_PFN_OFFSET_MAP > o dev->dma_pfn_map => dev->dma_pfn_offset_map > o s/frm/from/ for dma_pfn_offset_frm_{phys,dma}_addr() (Christoph) > o In device.h: s/const void */const struct dma_pfn_offset_region */ > o removed 'unlikely' from unlikely(dev->dma_pfn_offset_map) since > guarded by CONFIG_DMA_PFN_OFFSET_MAP (Christoph) > o Since dev->dma_pfn_offset is copied in usb/core/{usb,message}.c, now > dev->dma_pfn_offset_map is copied as well. > o Merged two of the DMA commits into one (Christoph). > > Commit "arm: dma-mapping: Invoke dma offset func if needed": > o Use helper functions instead of #if CONFIG_DMA_PFN_OFFSET > > Other commits' changes: > o Removed need for carrying of_id var in priv (Nicolas) > o Commit message rewordings (Bjorn) > o Commit log messages filled to 75 chars (Bjorn) > o devm_reset_control_get_shared()) > => devm_reset_control_get_optional_shared (Philipp) > o Add call to reset_control_assert() in PCIe remove routines (Philipp) > > v1: > This patchset expands the usefulness of the Broadcom Settop Box PCIe > controller by building upon the PCIe driver used currently by the > Raspbery Pi. Other forms of this patchset were submitted by me years > ago and not accepted; the major sticking point was the code required > for the DMA remapping needed for the PCIe driver to work [1]. > > There have been many changes to the DMA and OF subsystems since that > time, making a cleaner and less intrusive patchset possible. This > patchset implements a generalization of "dev->dma_pfn_offset", except > that instead of a single scalar offset it provides for multiple > offsets via a function which depends upon the "dma-ranges" property of > the PCIe host controller. This is required for proper functionality > of the BrcmSTB PCIe controller and possibly some other devices. If you can enable the h/w support without the multiple offset support, then I'd split up this series. The latter part might take a bit more time. Rob