Re: [PATCH v3 1/2] dt-bindings: Add ch7322 media i2c device

[Rob Herring <robh@kernel.org>]

On Thu, May 28, 2020 at 11:00:11PM -0400, Jeff Chase wrote:
> The ch7322 is a Chrontel CEC controller.
> 
> Signed-off-by: Jeff Chase <jnchase@google.com>
> ---
>  .../bindings/media/i2c/chrontel,ch7322.yaml   | 65 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  MAINTAINERS                                   |  7 ++
>  3 files changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml b/Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml
> new file mode 100644
> index 000000000000..d5706e08164c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/chrontel,ch7322.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/media/i2c/chrontel,ch7322.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Chrontel HDMI-CEC Controller
> +
> +maintainers:
> +  - Jeff Chase <jnchase@google.com>
> +
> +description: |-

Can drop the '|-' as you don't need any formatting.

> +  The Chrontel CH7322 is a discrete HDMI-CEC controller. It is
> +  programmable through I2C and drives a single CEC line.
> +
> +properties:
> +  compatible:
> +    const: chrontel,ch7322
> +
> +  reg:
> +    description: I2C device address
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: |-
> +      Reference to the GPIO connected to the RESET pin, if any. This
> +      pin is active-low.

How many? (maxItems: 1)

> +
> +  standby-gpios:

How many?

> +    description: |-
> +      Reference to the GPIO connected to the OE pin, if any. When low
> +      the device will respond to power status requests with "standby"
> +      if in auto mode.
> +
> +  # see ../cec.txt
> +  hdmi-phandle:
> +    description: phandle to the HDMI controller
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      ch7322@75 {
> +        compatible = "chrontel,ch7322";
> +        reg = <0x75>;
> +        interrupts = <47 IRQ_TYPE_EDGE_RISING>;
> +        standby-gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +        reset-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> +        hdmi-phandle = <&hdmi>;
> +      };
> +    };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index d3891386d671..7794ffccd325 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -187,6 +187,8 @@ patternProperties:
>      description: ChipOne
>    "^chipspark,.*":
>      description: ChipSPARK
> +  "^chrontel,.*":
> +    description: Chrontel, Inc.
>    "^chrp,.*":
>      description: Common Hardware Reference Platform
>    "^chunghwa,.*":
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d633a131dcd7..34c6d30e61e5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4047,6 +4047,13 @@ F:	drivers/power/supply/cros_usbpd-charger.c
>  N:	cros_ec
>  N:	cros-ec
>  
> +CHRONTEL CH7322 CEC DRIVER
> +M:	Jeff Chase <jnchase@google.com>
> +L:	linux-media@vger.kernel.org
> +S:	Maintained
> +T:	git git://linuxtv.org/media_tree.git
> +F:	Documentation/devicetree/bindings/media/i2c/chontel,ch7322.yaml
> +
>  CIRRUS LOGIC AUDIO CODEC DRIVERS
>  M:	James Schulman <james.schulman@cirrus.com>
>  M:	David Rhodes <david.rhodes@cirrus.com>
> -- 
> 2.27.0.rc0.183.gde8f92d652-goog
>